kernel: timer: Call user handler without spinlock

nordic-krch · nashif · commit 8979fbc906b3 · 2021-11-08T11:05:49.000-05:00
Add spinlock unlocking before calling timer expiration handler. Locking was introduced by dde3d6c. Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
diff --git a/kernel/timer.c b/kernel/timer.c
@@ -43,7 +43,10 @@ void z_timer_expiration_handler(struct _timeout *t)
 
 	/* invoke timer expiry function */
 	if (timer->expiry_fn != NULL) {
+		/* Unlock for user handler. */
+		k_spin_unlock(&lock, key);
 		timer->expiry_fn(timer);
+		key = k_spin_lock(&lock);
 	}
 
 	if (!IS_ENABLED(CONFIG_MULTITHREADING)) {

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,10 @@ void z_timer_expiration_handler(struct _timeout *t)`
`43`	`43`
`44`	`44`	`/* invoke timer expiry function */`
`45`	`45`	`if (timer->expiry_fn != NULL) {`
	`46`	`+ /* Unlock for user handler. */`
	`47`	`+ k_spin_unlock(&lock, key);`
`46`	`48`	`timer->expiry_fn(timer);`
	`49`	`+ key = k_spin_lock(&lock);`
`47`	`50`	`}`
`48`	`51`
`49`	`52`	`if (!IS_ENABLED(CONFIG_MULTITHREADING)) {`