Skip to content

Commit 8ad23f8

Browse files
marc-hbkartben
authored andcommitted
twister: add space in custom_flash_scripts example and test
This makes sure parsers don't trip over whitespace (as many do). I suggested this late in #93944 Signed-off-by: Marc Herbert <[email protected]>
1 parent 2b24a49 commit 8ad23f8

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

doc/develop/test/twister.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1456,19 +1456,19 @@ in a hardware map.
14561456
.. code-block:: bash
14571457
14581458
twister -p npcx9m6f_evb --device-testing --device-serial /dev/ttyACM0
1459-
--flash-command './custom_flash_script.py,--flag,"complex,argument"'
1459+
--flash-command './custom_flash_script.py,--flag,"complex, argument"'
14601460
14611461
.. group-tab:: Windows
14621462

14631463
.. note::
14641464

14651465
python .\scripts\twister -p npcx9m6f_evb --device-testing
14661466
--device-serial COM1
1467-
--flash-command 'custom_flash_script.py,--flag,"complex,argument"'
1467+
--flash-command 'custom_flash_script.py,--flag,"complex, argument"'
14681468

14691469
Would result in calling ``./custom_flash_script.py
14701470
--build-dir <build directory> --board-id <board identification>
1471-
--flag complex,argument``.
1471+
--flag "complex, argument"``.
14721472

14731473
Fixtures
14741474
+++++++++

scripts/tests/twister/test_handlers.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1157,9 +1157,9 @@ def mock_availability(handler, instance, no=num_of_failures):
11571157
None,
11581158
None,
11591159
None,
1160-
'path to/flash_command,with,args,"1,2,3",4',
1160+
'path to/flash_command,with,args,"1, 2, 3",4',
11611161
['path to/flash_command', '--build-dir', '$build_dir', '--board-id',
1162-
12345, 'with', 'args', '1,2,3', '4']
1162+
12345, 'with', 'args', '1, 2, 3', '4']
11631163
),
11641164
]
11651165

0 commit comments

Comments
 (0)