mgmt: mcumgr: transport: dummy: Fix issue with large packets

nordicjm · nordicjm · commit 8f4730b74cce · 2022-12-05T11:21:39.000Z
Fixes an issue with large packets being received, these packets are
chunked into 127-byte frames for the serial transport but this system
is not needed for the dummy transport as it has a fixed size buffer.

Signed-off-by: Jamie McCrae &lt;jamie.mccrae@nordicsemi.no&gt;
diff --git a/subsys/mgmt/mcumgr/transport/src/smp_dummy.c b/subsys/mgmt/mcumgr/transport/src/smp_dummy.c
@@ -11,6 +11,7 @@
 
 /* Define required for uart_mcumgr.h functionality reuse */
 #define CONFIG_UART_MCUMGR_RX_BUF_SIZE CONFIG_MCUMGR_SMP_DUMMY_RX_BUF_SIZE
+#define MCUMGR_DUMMY_MAX_FRAME CONFIG_MCUMGR_SMP_DUMMY_RX_BUF_SIZE
 
 #include <zephyr/kernel.h>
 #include <zephyr/init.h>
@@ -581,7 +582,7 @@ int mcumgr_dummy_tx_frame(const uint8_t *data, bool first, int len,
 	}
 
 	while (1) {
-		if (dst_off >= MCUMGR_SERIAL_MAX_FRAME - 4) {
+		if (dst_off >= MCUMGR_DUMMY_MAX_FRAME - 4) {
 			/* Can't fit any more data in this frame. */
 			break;
 		}

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,7 @@`
`11`	`11`
`12`	`12`	`/* Define required for uart_mcumgr.h functionality reuse */`
`13`	`13`	`#define CONFIG_UART_MCUMGR_RX_BUF_SIZE CONFIG_MCUMGR_SMP_DUMMY_RX_BUF_SIZE`
	`14`	`+#define MCUMGR_DUMMY_MAX_FRAME CONFIG_MCUMGR_SMP_DUMMY_RX_BUF_SIZE`
`14`	`15`
`15`	`16`	`#include <zephyr/kernel.h>`
`16`	`17`	`#include <zephyr/init.h>`
`@@ -581,7 +582,7 @@ int mcumgr_dummy_tx_frame(const uint8_t *data, bool first, int len,`
`581`	`582`	`}`
`582`	`583`
`583`	`584`	`while (1) {`
`584`		`- if (dst_off >= MCUMGR_SERIAL_MAX_FRAME - 4) {`
	`585`	`+ if (dst_off >= MCUMGR_DUMMY_MAX_FRAME - 4) {`
`585`	`586`	`/* Can't fit any more data in this frame. */`
`586`	`587`	`break;`
`587`	`588`	`}`