drivers: video: gc2145: return 0 at the end of functions

josuah · mmahadevan108 · commit 9174cb75e90e · 2024-09-28T11:30:08.000-05:00
After the error code is checked to be zero, it is possible to return 0
explicitly to help with readability. Also, when available, forward the
return code from the failing function instead of a locally chosen error
code like -EIO.

Signed-off-by: Josuah Demangeon &lt;me@josuah.net&gt;
diff --git a/drivers/video/gc2145.c b/drivers/video/gc2145.c
@@ -876,7 +876,7 @@ static int gc2145_set_window(const struct device *dev, uint16_t reg, uint16_t x,
 		return ret;
 	}
 
-	return ret;
+	return 0;
 }
 
 static int gc2145_set_output_format(const struct device *dev, int output_format)
@@ -1155,9 +1155,10 @@ static int gc2145_init(const struct device *dev)
 	ret = gc2145_set_fmt(dev, VIDEO_EP_OUT, &fmt);
 	if (ret) {
 		LOG_ERR("Unable to configure default format");
-		return -EIO;
+		return ret;
 	}
-	return ret;
+
+	return 0;
 }
 
 /* Unique Instance */

Original file line number	Diff line number	Diff line change
`@@ -876,7 +876,7 @@ static int gc2145_set_window(const struct device *dev, uint16_t reg, uint16_t x,`
`876`	`876`	`return ret;`
`877`	`877`	`}`
`878`	`878`
`879`		`- return ret;`
	`879`	`+ return 0;`
`880`	`880`	`}`
`881`	`881`
`882`	`882`	`static int gc2145_set_output_format(const struct device *dev, int output_format)`
`@@ -1155,9 +1155,10 @@ static int gc2145_init(const struct device *dev)`
`1155`	`1155`	`ret = gc2145_set_fmt(dev, VIDEO_EP_OUT, &fmt);`
`1156`	`1156`	`if (ret) {`
`1157`	`1157`	`LOG_ERR("Unable to configure default format");`
`1158`		`- return -EIO;`
	`1158`	`+ return ret;`
`1159`	`1159`	`}`
`1160`		`- return ret;`
	`1160`	`+`
	`1161`	`+ return 0;`
`1161`	`1162`	`}`
`1162`	`1163`
`1163`	`1164`	`/* Unique Instance */`