Skip to content

Commit 91cbbe8

Browse files
jacobwfabiobaltieri
authored andcommitted
boards: adaftuit feather nrf52840 Kconfig updates
Remove unnecessary Kconfig options. Simplify configuration by removing custom Kconfig option. Make Kconfig generic for all boards by moving usb selection to board_defconfig. These changes should enable the boards to become variants instead. Signed-off-by: Jacob Winther <[email protected]>
1 parent 3138f01 commit 91cbbe8

File tree

3 files changed

+9
-57
lines changed

3 files changed

+9
-57
lines changed

boards/adafruit/feather_nrf52840/Kconfig

Lines changed: 0 additions & 12 deletions
This file was deleted.

boards/adafruit/feather_nrf52840/Kconfig.defconfig

Lines changed: 0 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -9,46 +9,4 @@ if (BOARD_ADAFRUIT_FEATHER_NRF52840_EXPRESS || BOARD_ADAFRUIT_FEATHER_NRF52840_S
99
config BT_CTLR
1010
default BT
1111

12-
if BOARD_SERIAL_BACKEND_CDC_ACM
13-
14-
config USB_DEVICE_STACK
15-
default y
16-
17-
config USB_CDC_ACM
18-
default SERIAL
19-
20-
config UART_CONSOLE
21-
default CONSOLE
22-
23-
config USB_DEVICE_INITIALIZE_AT_BOOT
24-
default y if CONSOLE
25-
26-
config SHELL_BACKEND_SERIAL_CHECK_DTR
27-
default SHELL
28-
depends on UART_LINE_CTRL
29-
30-
config UART_LINE_CTRL
31-
default SHELL
32-
33-
config USB_DEVICE_REMOTE_WAKEUP
34-
default n
35-
36-
if LOG
37-
38-
# Logger cannot use itself to log
39-
config USB_CDC_ACM_LOG_LEVEL
40-
default 0
41-
42-
# Set USB log level to error only
43-
config USB_DEVICE_LOG_LEVEL
44-
default 1
45-
46-
# Wait 1500ms at startup for logging
47-
config LOG_PROCESS_THREAD_STARTUP_DELAY_MS
48-
default 1500
49-
50-
endif # LOG
51-
52-
endif # BOARD_SERIAL_BACKEND_CDC_ACM
53-
5412
endif # BOARD_ADAFRUIT_FEATHER_NRF52840_EXPRESS || BOARD_ADAFRUIT_FEATHER_NRF52840_SENSE

boards/adafruit/feather_nrf52840/adafruit_feather_nrf52840_sense_defconfig

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,19 +3,25 @@
33
# Enable MPU
44
CONFIG_ARM_MPU=y
55

6-
# enable GPIO
6+
# Enable GPIO
77
CONFIG_GPIO=y
88

9-
# enable uart driver
9+
# Enable UART driver
1010
CONFIG_SERIAL=y
1111

12-
# enable console
12+
# Enable console
1313
CONFIG_CONSOLE=y
1414
CONFIG_UART_CONSOLE=y
1515

1616
# 32kHz clock source
1717
CONFIG_CLOCK_CONTROL_NRF_K32SRC_RC=y
1818
CONFIG_CLOCK_CONTROL_NRF_K32SRC_500PPM=y
1919

20+
# Logger cannot use itself to log
21+
CONFIG_USB_CDC_ACM_LOG_LEVEL_OFF=y
22+
23+
# Enable USB
24+
CONFIG_USB_DEVICE_STACK=y
25+
2026
# Build UF2 by default, supported by the Adafruit nRF52 Bootloader
2127
CONFIG_BUILD_OUTPUT_UF2=y

0 commit comments

Comments
 (0)