net: http: Fix http_prepare_and_send

net_pkt_append() has been changed. If payload reached max value
of 'data_len' in net packet, net_pkt_append will not append.
So the caller has to create new packet and append remaining payload.

Signed-off-by: Ravi kumar Veeramally <[email protected]>

Author: rveerama1

subsys/net/lib/http/http.c

@@ -139,24 +139,37 @@ int http_prepare_and_send(struct http_ctx *ctx,
 
 		ret = net_pkt_append(ctx->pending, payload_len, payload,
 				     ctx->timeout);
+		if (!ret || ret > payload_len) {
+			ret = -EINVAL;
+			goto error;
+		}
 
 		added = ret;
 
-		if (added < payload_len) {
-			/* Not all data could be added, send what we have now
-			 * and allocate new stuff to be sent.
-			 */
-			ret = http_send_flush(ctx, user_send_data);
-			if (ret < 0) {
-				return ret;
-			}
-
-			payload_len -= added;
+		payload_len -= added;
+		if (payload_len) {
 			payload += added;
 		}
-	} while (added < payload_len);
+
+		/* Not all data could be added, send what we have now
+		 * and allocate new stuff to be sent.
+		 */
+		ret = http_send_flush(ctx, user_send_data);
+		if (ret < 0) {
+			goto error;
+		}
+
+	} while (payload_len);
 
 	return 0;
+
+error:
+	if (ctx->pending) {
+		net_pkt_unref(ctx->pending);
+		ctx->pending = NULL;
+	}
+
+	return ret;
 }
 
 int http_send_flush(struct http_ctx *ctx, void *user_send_data)