twister: status inconsistencies are now warnings

Do not report status issues as errors, very confusing and developer end
up looking at the wrong thing, instead, treat those as warnings and
count them and report them at the end.

Signed-off-by: Anas Nashif <[email protected]>

Author: nashif

scripts/pylib/twister/twisterlib/reports.py

@@ -596,7 +596,7 @@ def summary(self, results, ignore_unrecognized_sections, duration):
             f" {f'{TwisterStatus.get_color(TwisterStatus.NOTRUN)}{results.notrun}{Fore.RESET}' if results.notrun else f'{results.notrun}'} built (not run),"
             f" {f'{TwisterStatus.get_color(TwisterStatus.FAIL)}{results.failed}{Fore.RESET}' if results.failed else f'{results.failed}'} failed,"
             f" {f'{TwisterStatus.get_color(TwisterStatus.ERROR)}{results.error}{Fore.RESET}' if results.error else f'{results.error}'} errored,"
-            f" with {f'{Fore.YELLOW}{self.plan.warnings}{Fore.RESET}' if self.plan.warnings else 'no'} warnings"
+            f" with {f'{Fore.YELLOW}{self.plan.warnings + results.warnings}{Fore.RESET}' if (self.plan.warnings + results.warnings) else 'no'} warnings"
             f" in {duration:.2f} seconds."
         )
 

scripts/pylib/twister/twisterlib/runner.py

@@ -129,6 +129,7 @@ def __init__(self, total=0):
         self._none_cases = Value('i', 0)
         self._started_cases = Value('i', 0)
 
+        self._warnings = Value('i', 0)
 
         self.lock = Lock()
 
@@ -186,6 +187,20 @@ def summary(self):
             print(f"   └─ {'Test cases only started: ':<25}{self.started_cases:>{executed_cases_n_length}}")
         print("--------------------------------------------------")
 
+    @property
+    def warnings(self):
+        with self._warnings.get_lock():
+            return self._warnings.value
+
+    @warnings.setter
+    def warnings(self, value):
+        with self._warnings.get_lock():
+            self._warnings.value = value
+
+    def warnings_increment(self, value=1):
+        with self._warnings.get_lock():
+            self._warnings.value += value
+
     @property
     def cases(self):
         with self._cases.get_lock():
@@ -1324,15 +1339,18 @@ def _add_instance_testcases_to_status_counts(instance, results, decrement=False)
                 # but having those statuses in this part of processing is an error.
                 case TwisterStatus.NONE:
                     results.none_cases_increment(increment_value)
-                    logger.error(f'A None status detected in instance {instance.name},'
+                    logger.warning(f'A None status detected in instance {instance.name},'
                                  f' test case {tc.name}.')
+                    results.warnings_increment(1)
                 case TwisterStatus.STARTED:
                     results.started_cases_increment(increment_value)
-                    logger.error(f'A started status detected in instance {instance.name},'
+                    logger.warning(f'A started status detected in instance {instance.name},'
                                  f' test case {tc.name}.')
+                    results.warnings_increment(1)
                 case _:
-                    logger.error(f'An unknown status "{tc.status}" detected in instance {instance.name},'
+                    logger.warning(f'An unknown status "{tc.status}" detected in instance {instance.name},'
                                  f' test case {tc.name}.')
+                    results.warnings_increment(1)
 
 
     def report_out(self, results):