mgmt: hawkbit: Fix cancelAction string handling

maass-hamburg · github-actions[bot] · commit 994b37007095 · 2025-05-08T13:56:37.000Z
Fix off-by-one error in cancelAction string handling. Signed-off-by: Fin Maaß <f.maass@vogl-electronic.com> (cherry picked from commit c4ff1db)
diff --git a/subsys/mgmt/hawkbit/hawkbit.c b/subsys/mgmt/hawkbit/hawkbit.c
@@ -638,7 +638,7 @@ static int hawkbit_find_cancel_action_id(struct hawkbit_ctl_res *res,
 		return -EINVAL;
 	}
 
-	helper += sizeof("cancelAction/");
+	helper += sizeof("cancelAction/") - 1;
 
 	*cancel_action_id = strtol(helper, NULL, 10);
 	if (*cancel_action_id <= 0) {

Original file line number	Diff line number	Diff line change
`@@ -638,7 +638,7 @@ static int hawkbit_find_cancel_action_id(struct hawkbit_ctl_res *res,`
`638`	`638`	`return -EINVAL;`
`639`	`639`	`}`
`640`	`640`
`641`		`- helper += sizeof("cancelAction/");`
	`641`	`+ helper += sizeof("cancelAction/") - 1;`
`642`	`642`
`643`	`643`	`*cancel_action_id = strtol(helper, NULL, 10);`
`644`	`644`	`if (*cancel_action_id <= 0) {`