drivers: eeprom: stm32: simplify write error handling

haiyuewa · kartben · commit 99f4a078d25b · 2025-04-09T06:53:50.000+02:00
Remove the extra unlock and value return, just print the error code when
failed to do DATAEEPROM_Lock().

Signed-off-by: Haiyue Wang &lt;haiyuewa@163.com&gt;
diff --git a/drivers/eeprom/eeprom_stm32.c b/drivers/eeprom/eeprom_stm32.c
@@ -91,8 +91,6 @@ static int eeprom_stm32_write(const struct device *dev, off_t offset,
 	ret = HAL_FLASHEx_DATAEEPROM_Lock();
 	if (ret) {
 		LOG_ERR("failed to lock EEPROM (err %d)", ret);
-		k_mutex_unlock(&lock);
-		return ret;
 	}
 
 	k_mutex_unlock(&lock);

Original file line number	Diff line number	Diff line change
`@@ -91,8 +91,6 @@ static int eeprom_stm32_write(const struct device *dev, off_t offset,`
`91`	`91`	`ret = HAL_FLASHEx_DATAEEPROM_Lock();`
`92`	`92`	`if (ret) {`
`93`	`93`	`LOG_ERR("failed to lock EEPROM (err %d)", ret);`
`94`		`- k_mutex_unlock(&lock);`
`95`		`- return ret;`
`96`	`94`	`}`
`97`	`95`
`98`	`96`	`k_mutex_unlock(&lock);`