Skip to content

Commit 9c03497

Browse files
committed
boards: clean up CDC ACM configuration for nRF52840 based boards
Remove CDC ACM UART devicetree nodes, chosen properties and explicit USB support configuration in favor of generic CDC ACM shield. For console support via USB CDC ACM, in-tree samples for this boards is to be built as follows: west build -b nrf52840dongle_nrf52840 samples/basic/threads -- -DSHIELD=cdc_acm_console For shell support via USB CDC ACM, in-tree samples for this boards is to be built as follows: west build -b bl654_usb samples/subsys/shell/shell_module -- -DSHIELD=cdc_acm_shell Signed-off-by: Johann Fischer <[email protected]>
1 parent 74b92d7 commit 9c03497

File tree

8 files changed

+2
-65
lines changed

8 files changed

+2
-65
lines changed

boards/arm/arduino_nano_33_ble/Kconfig.board

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,6 @@ config BOARD_ARDUINO_NANO_33_BLE
55
bool "Arduino Nano 33 BLE board"
66
depends on SOC_NRF52840_QIAA
77

8-
config BOARD_ARDUINO_NANO_33_BLE_EN_USB_CONSOLE
9-
bool "Sends the console output over the USB port"
10-
depends on BOARD_ARDUINO_NANO_33_BLE
11-
select SERIAL
12-
select USB_DEVICE_STACK
13-
select CONSOLE
14-
select PRINTK
15-
select UART_INTERRUPT_DRIVEN
16-
select USB_UART_CONSOLE
17-
188
config BOARD_ARDUINO_NANO_33_BLE_INIT_SENSORS
199
bool "Initializes the internal I2C sensors on the board"
2010
depends on BOARD_ARDUINO_NANO_33_BLE

boards/arm/bl654_usb/Kconfig.defconfig

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -23,16 +23,6 @@ config FLASH_LOAD_OFFSET
2323
default 0x1000
2424
depends on !USE_DT_CODE_PARTITION
2525

26-
if USB_DEVICE_STACK
27-
28-
config USB_UART_CONSOLE
29-
default y
30-
31-
config UART_LINE_CTRL
32-
default y
33-
34-
endif # USB_DEVICE_STACK
35-
3626
if IEEE802154
3727

3828
config IEEE802154_NRF5

boards/arm/bl654_usb/bl654_usb.dts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,6 @@
1414
chosen {
1515
zephyr,sram = &sram0;
1616
zephyr,flash = &flash0;
17-
zephyr,console = &bl654_cdc_acm_uart;
18-
zephyr,shell-uart = &bl654_cdc_acm_uart;
19-
zephyr,bt-c2h-uart = &bl654_cdc_acm_uart;
2017
zephyr,code-partition = &slot0_partition;
2118
};
2219

@@ -104,9 +101,4 @@
104101
zephyr_udc0: &usbd {
105102
compatible = "nordic,nrf-usbd";
106103
status = "okay";
107-
108-
bl654_cdc_acm_uart: bl654_cdc_acm_uart {
109-
compatible = "zephyr,cdc-acm-uart";
110-
label = "CDC_ACM_0";
111-
};
112104
};

boards/arm/bl654_usb/bl654_usb_defconfig

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@ CONFIG_CONSOLE=y
1616
# Enable GPIO
1717
CONFIG_GPIO=y
1818

19-
# Enable USB
20-
CONFIG_USB_DEVICE_STACK=y
21-
2219
# Additional board options
2320
CONFIG_GPIO_AS_PINRESET=y
2421

boards/arm/degu_evk/Kconfig.defconfig

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -8,22 +8,6 @@ if BOARD_DEGU_EVK
88
config BOARD
99
default "degu_evk"
1010

11-
if USB_DEVICE_STACK
12-
13-
config USB_DEVICE_PRODUCT
14-
default "Degu Evaluation Kit"
15-
16-
config USB_UART_CONSOLE
17-
default y
18-
19-
config UART_INTERRUPT_DRIVEN
20-
default y
21-
22-
config UART_LINE_CTRL
23-
default y
24-
25-
endif # USB_DEVICE_STACK
26-
2711
if DISK_DRIVER_FLASH
2812

2913
config DISK_FLASH_DEV_NAME

boards/arm/degu_evk/degu_evk.dts

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
chosen {
1515
zephyr,sram = &sram0;
1616
zephyr,flash = &flash0;
17-
zephyr,console = &degu_cdc_acm_uart;
18-
zephyr,shell-uart = &degu_cdc_acm_uart;
17+
zephyr,console = &uart0;
18+
zephyr,shell-uart = &uart0;
1919
zephyr,code-partition = &slot0_partition;
2020
};
2121

@@ -143,9 +143,4 @@
143143
zephyr_udc0: &usbd {
144144
compatible = "nordic,nrf-usbd";
145145
status = "okay";
146-
147-
degu_cdc_acm_uart: degu_cdc_acm_uart {
148-
compatible = "zephyr,cdc-acm-uart";
149-
label = "CDC_ACM_0";
150-
};
151146
};

boards/arm/degu_evk/degu_evk_defconfig

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@ CONFIG_SERIAL=y
1212
CONFIG_CONSOLE=y
1313
CONFIG_UART_CONSOLE=y
1414

15-
# enable USB
16-
CONFIG_USB_DEVICE_STACK=y
17-
1815
# additional board options
1916
CONFIG_GPIO=y
2017
CONFIG_GPIO_AS_PINRESET=y

boards/arm/nrf52840dongle_nrf52840/Kconfig.defconfig

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,6 @@ config FLASH_LOAD_OFFSET
2424
default 0x1000
2525
depends on BOARD_HAS_NRF5_BOOTLOADER && !USE_DT_CODE_PARTITION
2626

27-
if USB_DEVICE_STACK
28-
29-
# Enable UART driver, needed for CDC ACM
30-
config SERIAL
31-
default y
32-
33-
endif # USB_DEVICE_STACK
34-
3527
config BT_CTLR
3628
default BT
3729

0 commit comments

Comments
 (0)