drivers: led: is31fl319x add is31fl3197 support

Add the registers and the like to the .c file plus add a Kconf file
plus bindings.

Updated example sketch: to also check for
is31fl3197 boards

Signed-off-by: Kurt Eckhardt <[email protected]>

Author: KurtE

drivers/led/CMakeLists.txt

@@ -7,6 +7,7 @@ zephyr_library()
 # zephyr-keep-sorted-start
 zephyr_library_sources_ifdef(CONFIG_HT16K33 ht16k33.c)
 zephyr_library_sources_ifdef(CONFIG_IS31FL3194 is31fl319x.c)
+zephyr_library_sources_ifdef(CONFIG_IS31FL3197 is31fl319x.c)
 zephyr_library_sources_ifdef(CONFIG_IS31FL3216A is31fl3216a.c)
 zephyr_library_sources_ifdef(CONFIG_IS31FL3733 is31fl3733.c)
 zephyr_library_sources_ifdef(CONFIG_LEDS_GROUP_MULTICOLOR leds_group_multicolor.c)

drivers/led/Kconfig

@@ -32,6 +32,7 @@ source "drivers/led/Kconfig.dac"
 source "drivers/led/Kconfig.gpio"
 source "drivers/led/Kconfig.ht16k33"
 source "drivers/led/Kconfig.is31fl3194"
+source "drivers/led/Kconfig.is31fl3197"
 source "drivers/led/Kconfig.is31fl3216a"
 source "drivers/led/Kconfig.is31fl3733"
 source "drivers/led/Kconfig.leds-group-multicolor"

drivers/led/Kconfig.is31fl3197

@@ -0,0 +1,11 @@
+# Copyright (c) 2024 Arduino SA
+# SPDX-License-Identifier: Apache-2.0
+
+config IS31FL3197
+	bool "IS31FL3197 LED driver"
+	default y
+	depends on DT_HAS_ISSI_IS31FL3197_ENABLED
+	select I2C
+	help
+	  Enable LED driver for Lumissil Microsystems (a division of ISSI)
+	  IS31FL3197. This chip supports one RGB LED or 4 independent LEDs.

drivers/led/is31fl319x.c

@@ -38,7 +38,16 @@ struct is31f1319x_model {
 	const uint8_t led_channels[];
 };
 
+struct is31fl319x_config {
+	struct i2c_dt_spec bus;
+	uint8_t channel_count;
+	uint8_t num_leds;
+	const struct led_info *led_infos;
+	const uint8_t *current_limits;
+	const struct is31f1319x_model *regs;
+};
 
+/* IS31FL3194 model registers and values */
 #define IS31FL3194_PROD_ID_REG		0x00
 #define IS31FL3194_CONF_REG		0x01
 #define IS31FL3194_CURRENT_REG		0x03
@@ -53,6 +62,7 @@ struct is31f1319x_model {
 
 #define IS31FL3194_CHANNEL_COUNT 3
 
+#ifdef CONFIG_IS31FL3194
 static const struct is31f1319x_model is31f13194_model = {
 	/* register indexes */
 	.prod_id_reg = IS31FL3194_PROD_ID_REG,
@@ -69,15 +79,44 @@ static const struct is31f1319x_model is31f13194_model = {
 
 	/* channel output registers */
 	.led_channels = {IS31FL3194_OUT1_REG, IS31FL3194_OUT2_REG, IS31FL3194_OUT3_REG}};
+#endif
+
+/* IS31FL3197 model registers and values */
+#define IS31FL3197_PROD_ID_REG		0x00
+#define IS31FL3197_SHUTDOWN_REG		0x01
+#define IS31FL3197_OPER_CONFIG_REG	0x02
+#define IS31FL3197_OUT1_REG		0x10
+#define IS31FL3197_OUT2_REG		0x11
+#define IS31FL3197_OUT3_REG		0x12
+#define IS31FL3197_OUT4_REG		0x13
+#define IS31FL3197_UPDATE_REG		0x2b
+
+#define IS31FL3197_SHUTDOWN_REG_VAL	0xf1 /* enable all channels */
+#define IS31FL3197_OPER_CONFIG_REG_VAL	0xff /* set all to current level */
+#define IS31FL3197_UPDATE_VAL		0xc5
+
+#define IS31FL3197_CHANNEL_COUNT 4
+
+#ifdef CONFIG_IS31FL3197
+static const struct is31f1319x_model is31f13197_model = {
+	/* register indexes */
+	.prod_id_reg = IS31FL3197_PROD_ID_REG,
+	.shutdown_reg = IS31FL3197_SHUTDOWN_REG,
+	.conf_reg = IS31FL3197_OPER_CONFIG_REG,
+	.current_reg = REG_NOT_DEFINED,
+	.update_reg = IS31FL3197_UPDATE_REG,
 
-struct is31fl319x_config {
-	struct i2c_dt_spec bus;
-	uint8_t channel_count;
-	uint8_t num_leds;
-	const struct led_info *led_infos;
-	const uint8_t *current_limits;
-	const struct is31f1319x_model *regs;
+	/* values for those registers */
+	.prod_id_val = 0xff,
+	.shutdown_reg_val = IS31FL3197_SHUTDOWN_REG_VAL,
+	.conf_enable = IS31FL3197_OPER_CONFIG_REG_VAL,
+	.update_val = IS31FL3197_UPDATE_VAL,
+
+	/* channel output registers */
+	.led_channels = {IS31FL3197_OUT1_REG, IS31FL3197_OUT2_REG, IS31FL3197_OUT3_REG,
+			 IS31FL3197_OUT4_REG}
 };
+#endif
 
 static const struct led_info *is31fl319x_led_to_info(const struct is31fl319x_config *config,
 						     uint32_t led)
@@ -124,7 +163,7 @@ static int is31fl319x_write_channels(const struct device *dev, uint32_t start_ch
 {
 	const struct is31fl319x_config *config = dev->config;
 	const struct is31f1319x_model *regs = config->regs;
-	int ret;
+	int ret = 0;
 
 	if ((start_channel + num_channels) > config->channel_count) {
 		return -ENOTSUP;
@@ -210,10 +249,9 @@ static int is31fl319x_check_config(const struct device *dev)
 	const struct is31fl319x_config *config = dev->config;
 	const struct led_info *info;
 	uint8_t rgb_count = 0;
-	uint8_t i;
 
 	/* verify that number of leds defined is not > number of channels */
-	for (i = 0; i < config->num_leds; i++) {
+	for (int i = 0; i < config->num_leds; i++) {
 		info = &config->led_infos[i];
 		rgb_count += info->num_colors;
 	}
@@ -230,7 +268,7 @@ static int is31fl319x_init(const struct device *dev)
 	const struct is31fl319x_config *config = dev->config;
 	const struct led_info *info = NULL;
 	const struct is31f1319x_model *regs = config->regs;
-	int i, j, ret;
+	int ret;
 	uint8_t prod_id, band, channel;
 	uint8_t current_reg = 0;
 
@@ -250,20 +288,30 @@ static int is31fl319x_init(const struct device *dev)
 		return ret;
 	}
 
-	if (prod_id != regs->prod_id_val) {
-		LOG_ERR("%s: invalid product ID 0x%02x (expected 0x%02x)", dev->name, prod_id,
-			regs->prod_id_val);
-		return -ENODEV;
+	if (regs->prod_id_val != 0xff) {
+		if (prod_id != regs->prod_id_val) {
+			LOG_ERR("%s: invalid product ID 0x%02x (expected 0x%02x)", dev->name,
+				prod_id, regs->prod_id_val);
+			return -ENODEV;
+		}
+	} else {
+
+		/* The product ID (8 bit) should be the I2C address(7 bit) */
+		if (prod_id != (config->bus.addr << 1)) {
+			LOG_ERR("%s: invalid product ID 0x%02x (expected 0x%02x)", dev->name,
+				prod_id, config->bus.addr << 1);
+			return -ENODEV;
+		}
 	}
 
 	/* calc current limit register value */
 	if (regs->current_reg != REG_NOT_DEFINED) {
 		channel = 0;
-		for (i = 0; i < config->num_leds; i++) {
+		for (int i = 0; i < config->num_leds; i++) {
 			info = &config->led_infos[i];
 			band = (config->current_limits[i] / 10) - 1;
 
-			for (j = 0; j < info->num_colors; j++) {
+			for (int j = 0; j < info->num_colors; j++) {
 				current_reg |= band << (2 * channel);
 				channel++;
 			}
@@ -275,6 +323,15 @@ static int is31fl319x_init(const struct device *dev)
 			return ret;
 		}
 	}
+	if (regs->shutdown_reg != REG_NOT_DEFINED) {
+		ret = i2c_reg_write_byte_dt(&config->bus, regs->shutdown_reg,
+					    regs->shutdown_reg_val);
+		if (ret != 0) {
+			LOG_ERR("%s: failed to set current limit", dev->name);
+			return ret;
+		}
+	}
+
 	/* enable device */
 	return i2c_reg_write_byte_dt(&config->bus, regs->conf_reg,
 				     regs->conf_enable);
@@ -329,3 +386,8 @@ static DEVICE_API(led, is31fl319x_led_api) = {
 #define DT_DRV_COMPAT issi_is31fl3194
 DT_INST_FOREACH_STATUS_OKAY_VARGS(IS31FL319X_DEVICE, 4, IS31FL3194_CHANNEL_COUNT,
 				  &is31f13194_model)
+#undef DT_DRV_COMPAT
+#define DT_DRV_COMPAT issi_is31fl3197
+DT_INST_FOREACH_STATUS_OKAY_VARGS(IS31FL319X_DEVICE, 7, IS31FL3194_CHANNEL_COUNT,
+				  &is31f13197_model)
+#undef DT_DRV_COMPAT

dts/bindings/led/issi,is31fl3197.yaml

@@ -0,0 +1,80 @@
+# Copyright (c) 2024 Arduino SA
+# SPDX-License-Identifier: Apache-2.0
+
+description: |
+  IS31FL3197 4-channel LED driver with programmable pattern sequencing
+
+  This driver supports single-channel and RGB LEDs. For single channel LEDs,
+  the led_set_brightness() API can be used to set the brightness of each LED.
+  For RGB LEDs, the led_set_color() API can be used to set the red, green and
+  blue components; the driver takes care of routing to the outputs described
+  by the color-mapping property.
+
+  The LED_SHELL application can be used for testing.
+
+  The following shows configuration for Arduino Giga Display shield
+
+  This driver supports single-channel and RGB and maybe RGBW LEDs. For single
+  channel LEDs, the led_set_brightness() API can be used to set the brightness
+  of each LED. For RGB LEDs, the led_set_color() API can be used to set the red,
+  green and blue and white components; the driver takes care of routing to the
+  outputs described by the color-mapping property.
+
+  The LED_SHELL application can be used for testing.
+
+  The following defines a single RGB LED in the is31fl3197 DT node:
+
+    is31fl3197@50 {
+      compatible = "issi,is31fl3197";
+      reg = <0x50>;
+
+      led_0 {
+        label = "RGB LED";
+        color-mapping =
+          <LED_COLOR_ID_RED>,
+          <LED_COLOR_ID_GREEN>,
+          <LED_COLOR_ID_BLUE>;
+      };
+    };
+
+  The following example defines three single-channel LEDs in the is31fl3197 DT node:
+
+    is31fl3197@50 {
+      compatible = "issi,is31fl3197";
+      reg = <0x50>;
+
+      led_0 {
+        label = "RED LED";
+        color-mapping = <LED_COLOR_ID_RED>;
+      };
+
+      led_1 {
+        label = "GREEN LED";
+        color-mapping = <LED_COLOR_ID_GREEN>;
+      };
+
+      led_2 {
+        label = "BLUE LED";
+        color-mapping = <LED_COLOR_ID_BLUE>;
+      };
+    };
+
+compatible: "issi,is31fl3197"
+
+include: ["i2c-device.yaml", "led-controller.yaml"]
+
+child-binding:
+  properties:
+    label:
+      required: true
+
+    color-mapping:
+      required: true
+
+    current-limit:
+      type: int
+      default: 10
+      enum:
+        - 10
+      description: |
+        The current limit for the LED in mA.

samples/drivers/led/is31fl319x/README.rst

@@ -25,22 +25,15 @@ Building and Running
 
 This sample can be built and executed on an Arduino Nicla Sense ME, or on
 any board where the devicetree has an I2C device node with compatible
-:dtcompatible:`issi,is31fl3194` enabled, along with the relevant bus
-controller node also being enabled.
+:dtcompatible:`issi,is31fl3194` or :dtcompatible:`issi,is31fl319` with the
+relevant bus controller node also being enabled.
 
 .. zephyr-app-commands::
    :zephyr-app: samples/drivers/led/is31fl319x
    :board: arduino_nicla_sense_me
    :goals: build flash
    :compact:
 
-.. zephyr-app-commands::
-   :zephyr-app: samples/drivers/led/is31fl319x
-   :board: arduino_giga_r1//m7
-   :shield: arduino_giga_display_shield
-   :goals: build flash
-   :compact:
-
 After flashing, the LED starts to switch colors and messages with the current
 LED color are printed on the console. If a runtime error occurs, the sample
 exits without printing to the console.

samples/drivers/led/is31fl319x/src/main.c

@@ -31,10 +31,12 @@ static const struct color_data color_sequence[] = {
 };
 
 /*
- * A build error on this line means your board is unsupported.
+ * A build error on these lines means your board is unsupported.
  */
 #ifdef CONFIG_IS31FL3194
 const struct device *led = DEVICE_DT_GET_ANY(issi_is31fl3194);
+#elif defined(CONFIG_IS31FL3197)
+const struct device *led = DEVICE_DT_GET_ANY(issi_is31fl3197);
 #endif
 
 uint8_t rgb_mapping[3] = {0, 0, 0}; /* R G B */