Skip to content

Commit a1adced

Browse files
tmlemanhenrikbrixandersen
authored andcommitted
intel_adsp: ace: Remove redundant HPSRAM init from D3 restore
Remove hp_sram_init() call from boot_d3_restore() as it's redundant and causes TLB access errors. The TLB driver's adsp_mm_restore_context() already handles all HPSRAM power management and content restoration. The removed code was attempting to zero memory regions that are intentionally unmapped by the TLB driver for power optimization, causing access to disabled TLB entries during D3→D0 transitions. Additionally, hp_sram_init() powers up all memory banks while the TLB restore function correctly enables only the banks that were actually used, maintaining proper power optimization. Current flow causes errors in simulation which revealed this incorrect double initialization in test scenarios with minimal firmware configurations. Signed-off-by: Tomasz Leman <[email protected]>
1 parent 1418401 commit a1adced

File tree

1 file changed

+0
-4
lines changed
  • soc/intel/intel_adsp/ace

1 file changed

+0
-4
lines changed

soc/intel/intel_adsp/ace/boot.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,6 @@ __imr void boot_d3_restore(void)
4343
#ifdef CONFIG_ADSP_DISABLE_L2CACHE_AT_BOOT
4444
ADSP_L2PCFG_REG = 0;
4545
#endif
46-
47-
extern void hp_sram_init(uint32_t memory_size);
48-
hp_sram_init(L2_SRAM_SIZE);
49-
5046
extern void lp_sram_init(void);
5147
lp_sram_init();
5248

0 commit comments

Comments
 (0)