drivers: pm: add pm_policy_state_lock for drivers

Added pm_policy_state_lock to prevent memory power
off during data transfer

Signed-off-by: Hao Luo <[email protected]>

Author: AlessandroLuo

drivers/i2c/i2c_ambiq.c

@@ -47,8 +47,35 @@ struct i2c_ambiq_data {
 	void *callback_data;
 	int inst_idx;
 	uint32_t transfer_status;
+	bool pm_policy_state_on;
 };
 
+static void i2c_ambiq_pm_policy_state_lock_get(const struct device *dev)
+{
+	if (IS_ENABLED(CONFIG_PM)) {
+		struct i2c_ambiq_data *data = dev->data;
+
+		if (!data->pm_policy_state_on) {
+			data->pm_policy_state_on = true;
+			pm_policy_state_lock_get(PM_STATE_SUSPEND_TO_RAM, PM_ALL_SUBSTATES);
+			pm_device_runtime_get(dev);
+		}
+	}
+}
+
+static void i2c_ambiq_pm_policy_state_lock_put(const struct device *dev)
+{
+	if (IS_ENABLED(CONFIG_PM)) {
+		struct i2c_ambiq_data *data = dev->data;
+
+		if (data->pm_policy_state_on) {
+			data->pm_policy_state_on = false;
+			pm_device_runtime_put(dev);
+			pm_policy_state_lock_put(PM_STATE_SUSPEND_TO_RAM, PM_ALL_SUBSTATES);
+		}
+	}
+}
+
 #ifdef CONFIG_I2C_AMBIQ_DMA
 static __aligned(32) struct {
 	__aligned(32) uint32_t buf[CONFIG_I2C_DMA_TCB_BUFFER_SIZE];
@@ -183,17 +210,13 @@ static int i2c_ambiq_transfer(const struct device *dev, struct i2c_msg *msgs, ui
 			      uint16_t addr)
 {
 	struct i2c_ambiq_data *data = dev->data;
-	int pm_ret, ret = 0;
+	int ret = 0;
 
 	if (!num_msgs) {
 		return 0;
 	}
 
-	pm_ret = pm_device_runtime_get(dev);
-
-	if (pm_ret < 0) {
-		LOG_ERR("pm_device_runtime_get failed: %d", pm_ret);
-	}
+	i2c_ambiq_pm_policy_state_lock_get(dev);
 
 	/* Send out messages */
 	k_sem_take(&data->bus_sem, K_FOREVER);
@@ -213,16 +236,7 @@ static int i2c_ambiq_transfer(const struct device *dev, struct i2c_msg *msgs, ui
 
 	k_sem_give(&data->bus_sem);
 
-	/* Use async put to avoid useless device suspension/resumption
-	 * when doing consecutive transmission.
-	 */
-	if (!pm_ret) {
-		pm_ret = pm_device_runtime_put_async(dev, K_MSEC(2));
-
-		if (pm_ret < 0) {
-			LOG_ERR("pm_device_runtime_put failed: %d", pm_ret);
-		}
-	}
+	i2c_ambiq_pm_policy_state_lock_put(dev);
 
 	return ret;
 }

drivers/spi/spi_ambiq.c

@@ -42,6 +42,7 @@ struct spi_ambiq_data {
 	void *iom_handler;
 	int inst_idx;
 	bool cont;
+	bool pm_policy_state_on;
 };
 
 typedef void (*spi_context_update_trx)(struct spi_context *ctx, uint8_t dfs, uint32_t len);
@@ -50,6 +51,32 @@ typedef void (*spi_context_update_trx)(struct spi_context *ctx, uint8_t dfs, uin
 
 #define SPI_CS_INDEX 3
 
+static void spi_ambiq_pm_policy_state_lock_get(const struct device *dev)
+{
+	if (IS_ENABLED(CONFIG_PM)) {
+		struct spi_ambiq_data *data = dev->data;
+
+		if (!data->pm_policy_state_on) {
+			data->pm_policy_state_on = true;
+			pm_policy_state_lock_get(PM_STATE_SUSPEND_TO_RAM, PM_ALL_SUBSTATES);
+			pm_device_runtime_get(dev);
+		}
+	}
+}
+
+static void spi_ambiq_pm_policy_state_lock_put(const struct device *dev)
+{
+	if (IS_ENABLED(CONFIG_PM)) {
+		struct spi_ambiq_data *data = dev->data;
+
+		if (data->pm_policy_state_on) {
+			data->pm_policy_state_on = false;
+			pm_device_runtime_put(dev);
+			pm_policy_state_lock_put(PM_STATE_SUSPEND_TO_RAM, PM_ALL_SUBSTATES);
+		}
+	}
+}
+
 #ifdef CONFIG_SPI_AMBIQ_DMA
 static __aligned(32) struct {
 	__aligned(32) uint32_t buf[CONFIG_SPI_DMA_TCB_BUFFER_SIZE];
@@ -349,15 +376,11 @@ static int spi_ambiq_transceive(const struct device *dev, const struct spi_confi
 		return 0;
 	}
 
-	pm_ret = pm_device_runtime_get(dev);
-
-	if (pm_ret < 0) {
-		LOG_ERR("pm_device_runtime_get failed: %d", pm_ret);
-	}
-
 	/* context setup */
 	spi_context_lock(&data->ctx, false, NULL, NULL, config);
 
+	spi_ambiq_pm_policy_state_lock_get(dev);
+
 	ret = spi_config(dev, config);
 
 	if (ret) {
@@ -370,18 +393,9 @@ static int spi_ambiq_transceive(const struct device *dev, const struct spi_confi
 	ret = spi_ambiq_xfer(dev, config);
 
 xfer_end:
-	spi_context_release(&data->ctx, ret);
-
-	/* Use async put to avoid useless device suspension/resumption
-	 * when doing consecutive transmission.
-	 */
-	if (!pm_ret) {
-		pm_ret = pm_device_runtime_put_async(dev, K_MSEC(2));
+	spi_ambiq_pm_policy_state_lock_put(dev);
 
-		if (pm_ret < 0) {
-			LOG_ERR("pm_device_runtime_put failed: %d", pm_ret);
-		}
-	}
+	spi_context_release(&data->ctx, ret);
 
 	return ret;
 }

west.yml

@@ -147,7 +147,7 @@ manifest:
       groups:
         - hal
     - name: hal_ambiq
-      revision: df4a9863f87cf75dc0b4a8e47483c87363d0e8f0
+      revision: d3092f9b82874a1791baa3ac41c3795d108fbbdb
       path: modules/hal/ambiq
       groups:
         - hal