drivers: disk: Fix USDHC driver to return 0 on success

mmahadevan108 · nashif · commit a90c4c38a1c7 · 2021-09-17T08:12:22.000-04:00
The function usdhc_board_access_init was returning a non-zero
value as the variable "ret" is also used to store the GPIO
level for card-detect.

Signed-off-by: Mahesh Mahadevan &lt;mahesh.mahadevan@nxp.com&gt;
diff --git a/drivers/disk/usdhc.c b/drivers/disk/usdhc.c
@@ -2641,7 +2641,7 @@ static int usdhc_board_access_init(struct usdhc_priv *priv)
 			priv->inserted = true;
 		} else {
 			priv->inserted = false;
-			ret = -ENODEV;
+			return -ENODEV;
 		}
 	} else {
 		ret = usdhc_cd_gpio_init(priv->detect_gpio,
@@ -2668,7 +2668,7 @@ static int usdhc_board_access_init(struct usdhc_priv *priv)
 		priv->inserted = true;
 		LOG_INF("SD inserted!");
 	}
-	return ret;
+	return 0;
 }
 
 static int usdhc_access_init(const struct device *dev)

Original file line number	Diff line number	Diff line change
`@@ -2641,7 +2641,7 @@ static int usdhc_board_access_init(struct usdhc_priv *priv)`
`2641`	`2641`	`priv->inserted = true;`
`2642`	`2642`	`} else {`
`2643`	`2643`	`priv->inserted = false;`
`2644`		`- ret = -ENODEV;`
	`2644`	`+ return -ENODEV;`
`2645`	`2645`	`}`
`2646`	`2646`	`} else {`
`2647`	`2647`	`ret = usdhc_cd_gpio_init(priv->detect_gpio,`
`@@ -2668,7 +2668,7 @@ static int usdhc_board_access_init(struct usdhc_priv *priv)`
`2668`	`2668`	`priv->inserted = true;`
`2669`	`2669`	`LOG_INF("SD inserted!");`
`2670`	`2670`	`}`
`2671`		`- return ret;`
	`2671`	`+ return 0;`
`2672`	`2672`	`}`
`2673`	`2673`
`2674`	`2674`	`static int usdhc_access_init(const struct device *dev)`