drivers: i2s: stm32_sai fix tx callback mem_block release

mariopaja · kartben · commit abb3c2a472c0 · 2025-09-03T01:40:09.000+02:00
This change fixes a wrong buffer release on tx callback which was not correctly fixed by #94696. Signed-off-by: Mario Paja <mariopaja@hotmail.com>
diff --git a/drivers/i2s/i2s_stm32_sai.c b/drivers/i2s/i2s_stm32_sai.c
@@ -133,6 +133,7 @@ void HAL_SAI_TxCpltCallback(SAI_HandleTypeDef *hsai)
 {
 	struct i2s_stm32_sai_data *dev_data = CONTAINER_OF(hsai, struct i2s_stm32_sai_data, hsai);
 	struct stream *stream = &dev_data->stream;
+	void *mem_block_tmp = stream->mem_block;
 	struct queue_item item;
 	int ret;
 
@@ -183,7 +184,7 @@ void HAL_SAI_TxCpltCallback(SAI_HandleTypeDef *hsai)
 
 exit:
 	/* Free memory slab & exit */
-	k_mem_slab_free(stream->i2s_cfg.mem_slab, stream->mem_block);
+	k_mem_slab_free(stream->i2s_cfg.mem_slab, mem_block_tmp);
 }
 
 void HAL_SAI_ErrorCallback(SAI_HandleTypeDef *hsai)

Original file line number	Diff line number	Diff line change
`@@ -133,6 +133,7 @@ void HAL_SAI_TxCpltCallback(SAI_HandleTypeDef *hsai)`
`133`	`133`	`{`
`134`	`134`	`struct i2s_stm32_sai_data *dev_data = CONTAINER_OF(hsai, struct i2s_stm32_sai_data, hsai);`
`135`	`135`	`struct stream *stream = &dev_data->stream;`
	`136`	`+ void *mem_block_tmp = stream->mem_block;`
`136`	`137`	`struct queue_item item;`
`137`	`138`	`int ret;`
`138`	`139`
`@@ -183,7 +184,7 @@ void HAL_SAI_TxCpltCallback(SAI_HandleTypeDef *hsai)`
`183`	`184`
`184`	`185`	`exit:`
`185`	`186`	`/* Free memory slab & exit */`
`186`		`- k_mem_slab_free(stream->i2s_cfg.mem_slab, stream->mem_block);`
	`187`	`+ k_mem_slab_free(stream->i2s_cfg.mem_slab, mem_block_tmp);`
`187`	`188`	`}`
`188`	`189`
`189`	`190`	`void HAL_SAI_ErrorCallback(SAI_HandleTypeDef *hsai)`