Bluetooth: Host: Remove an indentation level in auto procedures

The else branch was unused.

Signed-off-by: Jonathan Rico <[email protected]>

Author: jori-nordic

include/zephyr/drivers/bluetooth.h

@@ -46,6 +46,14 @@ enum {
 	 * initial connection data length parameters are not equal to the
 	 * default data length parameters. Therefore the host should initiate
 	 * the DLE procedure after connection establishment.
+	 *
+	 * That requirement is stated in Core Spec v5.4 Vol 6 Part B. 4.5.10
+	 * Data PDU length management:
+	 *
+	 * > For a new connection:
+	 * > - ... If either value is not 27, then the Controller should
+	 * >   initiate the Data Length Update procedure at the earliest
+	 * >   practical opportunity.
 	 */
 	BT_HCI_QUIRK_NO_AUTO_DLE = BIT(1),
 };

subsys/bluetooth/host/conn.c

@@ -1764,23 +1764,20 @@ static void perform_auto_initiated_procedures(struct bt_conn *conn, void *unused
 		}
 	}
 
+	/* Data length should be automatically updated to the maximum by the
+	 * controller. Not updating it is a quirk and this is the workaround.
+	 */
 	if (IS_ENABLED(CONFIG_BT_AUTO_DATA_LEN_UPDATE) &&
-	    BT_FEAT_LE_DLE(bt_dev.le.features)) {
-		if (bt_drv_quirk_no_auto_dle()) {
-			uint16_t tx_octets, tx_time;
-
-			err = bt_hci_le_read_max_data_len(&tx_octets, &tx_time);
-			if (!err) {
-				err = bt_le_set_data_len(conn,
-						tx_octets, tx_time);
-				if (err) {
-					LOG_ERR("Failed to set data len (%d)", err);
-				}
+	    BT_FEAT_LE_DLE(bt_dev.le.features) &&
+	    bt_drv_quirk_no_auto_dle()) {
+		uint16_t tx_octets, tx_time;
+
+		err = bt_hci_le_read_max_data_len(&tx_octets, &tx_time);
+		if (!err) {
+			err = bt_le_set_data_len(conn, tx_octets, tx_time);
+			if (err) {
+				LOG_ERR("Failed to set data len (%d)", err);
 			}
-		} else {
-			/* No need to auto-initiate DLE procedure.
-			 * It is done by the controller.
-			 */
 		}
 	}