Skip to content

Commit ace6e44

Browse files
rluboshenrikbrixandersen
authored andcommitted
net: mqtt: Fix possible socket leak with websocket transport
In case underlying TCP/TLS connection is already down, the websocket_disconnect() call is expected to fail, as it involves communication. Therefore, mqtt_client_websocket_disconnect() should not quit early in such cases, as it could lead to an underlying socket leak. Signed-off-by: Robert Lubos <[email protected]> (cherry picked from commit 4625fa7)
1 parent 4769dbb commit ace6e44

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

subsys/net/lib/mqtt/mqtt_transport_websocket.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -174,8 +174,7 @@ int mqtt_client_websocket_disconnect(struct mqtt_client *client)
174174

175175
ret = websocket_disconnect(client->transport.websocket.sock);
176176
if (ret < 0) {
177-
NET_ERR("Websocket disconnect failed (%d)", ret);
178-
return ret;
177+
NET_DBG("Websocket disconnect failed (%d)", ret);
179178
}
180179

181180
if (client->transport.type == MQTT_TRANSPORT_NON_SECURE_WEBSOCKET) {

0 commit comments

Comments
 (0)