Skip to content

Commit b07fe48

Browse files
Flavio Ceolinandrewboie
authored andcommitted
power: Fix switch usage
According with MISRA-C every switch-clause must terminate with an unconditional break. MISRA-C rules 16.1 and 16.3 Signed-off-by: Flavio Ceolin <[email protected]>
1 parent 45c6ead commit b07fe48

File tree

1 file changed

+18
-11
lines changed

1 file changed

+18
-11
lines changed

include/power.h

Lines changed: 18 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -71,26 +71,29 @@ extern unsigned char sys_pm_idle_exit_notify;
7171
*/
7272
static inline bool sys_pm_is_low_power_state(enum power_states state)
7373
{
74+
bool ret = true;
75+
7476
switch (state) {
7577
#ifdef CONFIG_SYS_POWER_LOW_POWER_STATES
7678
# ifdef CONFIG_HAS_STATE_LOW_POWER_1
7779
case SYS_POWER_STATE_LOW_POWER_1:
78-
/* FALLTHROUGH */
80+
break;
7981
# endif
8082
# ifdef CONFIG_HAS_STATE_LOW_POWER_2
8183
case SYS_POWER_STATE_LOW_POWER_2:
82-
/* FALLTHROUGH */
84+
break;
8385
# endif
8486
# ifdef CONFIG_HAS_STATE_LOW_POWER_3
8587
case SYS_POWER_STATE_LOW_POWER_3:
86-
/* FALLTHROUGH */
88+
break;
8789
# endif
88-
return true;
8990
#endif /* CONFIG_SYS_POWER_LOW_POWER_STATES */
90-
9191
default:
92-
return false;
92+
ret = false;
93+
break;
9394
}
95+
96+
return ret;
9497
}
9598

9699
/**
@@ -100,26 +103,30 @@ static inline bool sys_pm_is_low_power_state(enum power_states state)
100103
*/
101104
static inline bool sys_pm_is_deep_sleep_state(enum power_states state)
102105
{
106+
bool ret = true;
107+
103108
switch (state) {
104109
#ifdef CONFIG_SYS_POWER_DEEP_SLEEP_STATES
105110
# ifdef CONFIG_HAS_STATE_DEEP_SLEEP_1
106111
case SYS_POWER_STATE_DEEP_SLEEP_1:
107-
/* FALLTHROUGH */
112+
break;
108113
# endif
109114
# ifdef CONFIG_HAS_STATE_DEEP_SLEEP_2
110115
case SYS_POWER_STATE_DEEP_SLEEP_2:
111-
/* FALLTHROUGH */
116+
break;
112117
# endif
113118
# ifdef CONFIG_HAS_STATE_DEEP_SLEEP_3
114119
case SYS_POWER_STATE_DEEP_SLEEP_3:
115-
/* FALLTHROUGH */
120+
break;
116121
# endif
117-
return true;
118122
#endif /* CONFIG_SYS_POWER_DEEP_SLEEP_STATES */
119123

120124
default:
121-
return false;
125+
ret = false;
126+
break;
122127
}
128+
129+
return ret;
123130
}
124131

125132
/**

0 commit comments

Comments
 (0)