drivers: display: stm32_ltdc: fix set orientation API

GeorgeCGV · carlescufi · commit b11fcc8e0c32 · 2022-05-11T10:49:23.000+02:00
Refactors invalid switch into if statement.
Fixes orientation set return value for normal
display orientation.

Signed-off-by: Georgij Cernysiov &lt;geo.cgv@gmail.com&gt;
diff --git a/drivers/display/display_stm32_ltdc.c b/drivers/display/display_stm32_ltdc.c
@@ -129,16 +129,13 @@ static int stm32_ltdc_set_pixel_format(const struct device *dev,
 static int stm32_ltdc_set_orientation(const struct device *dev,
 				const enum display_orientation orientation)
 {
-	int err;
+	ARG_UNUSED(dev);
 
-	switch (orientation) {
-	case DISPLAY_ORIENTATION_NORMAL:
-		err = 0;
-	default:
-		err = -ENOTSUP;
+	if (orientation == DISPLAY_ORIENTATION_NORMAL) {
+		return 0;
 	}
 
-	return err;
+	return -ENOTSUP;
 }
 
 static void stm32_ltdc_get_capabilities(const struct device *dev,

Original file line number	Diff line number	Diff line change
`@@ -129,16 +129,13 @@ static int stm32_ltdc_set_pixel_format(const struct device *dev,`
`129`	`129`	`static int stm32_ltdc_set_orientation(const struct device *dev,`
`130`	`130`	`const enum display_orientation orientation)`
`131`	`131`	`{`
`132`		`- int err;`
	`132`	`+ ARG_UNUSED(dev);`
`133`	`133`
`134`		`- switch (orientation) {`
`135`		`- case DISPLAY_ORIENTATION_NORMAL:`
`136`		`- err = 0;`
`137`		`- default:`
`138`		`- err = -ENOTSUP;`
	`134`	`+ if (orientation == DISPLAY_ORIENTATION_NORMAL) {`
	`135`	`+ return 0;`
`139`	`136`	`}`
`140`	`137`
`141`		`- return err;`
	`138`	`+ return -ENOTSUP;`
`142`	`139`	`}`
`143`	`140`
`144`	`141`	`static void stm32_ltdc_get_capabilities(const struct device *dev,`