net: utils: fix offset used before range check

szsam · nashif · commit b2c00ec032d9 · 2023-06-16T05:46:05.000-04:00
This use of offset 'i' should follow the range check.

Signed-off-by: Mingjie Shen &lt;shen497@purdue.edu&gt;
diff --git a/subsys/net/ip/utils.c b/subsys/net/ip/utils.c
@@ -894,7 +894,7 @@ bool net_ipaddr_parse(const char *str, size_t str_len, struct sockaddr *addr)
 		return parse_ipv6(str, str_len, addr, true);
 	}
 
-	for (count = i = 0; str[i] && i < str_len; i++) {
+	for (count = i = 0; i < str_len && str[i]; i++) {
 		if (str[i] == ':') {
 			count++;
 		}

Original file line number	Diff line number	Diff line change
`@@ -894,7 +894,7 @@ bool net_ipaddr_parse(const char str, size_t str_len, struct sockaddr addr)`
`894`	`894`	`return parse_ipv6(str, str_len, addr, true);`
`895`	`895`	`}`
`896`	`896`
`897`		`- for (count = i = 0; str[i] && i < str_len; i++) {`
	`897`	`+ for (count = i = 0; i < str_len && str[i]; i++) {`
`898`	`898`	`if (str[i] == ':') {`
`899`	`899`	`count++;`
`900`	`900`	`}`