modem: cmux: Optimize log message to save ROM

Bjarki Arge Andreasen · fabiobaltieri · commit b4f315059232 · 2023-10-24T14:31:38.000+01:00
This commit reuses the string "Unknown %s frame type" for two
log messages, as suggested by ycsin.

Signed-off-by: Bjarki Arge Andreasen &lt;bjarkix123@gmail.com&gt;
diff --git a/subsys/modem/modem_cmux.c b/subsys/modem/modem_cmux.c
@@ -449,7 +449,7 @@ static void modem_cmux_on_control_frame(struct modem_cmux *cmux)
 		break;
 
 	default:
-		LOG_WRN("Unknown control frame type");
+		LOG_WRN("Unknown %s frame type", "control");
 		break;
 	}
 }
@@ -533,7 +533,7 @@ static void modem_cmux_on_dlci_frame(struct modem_cmux *cmux)
 		break;
 
 	default:
-		LOG_WRN("Unknown DLCI frame type");
+		LOG_WRN("Unknown %s frame type", "DLCI");
 		break;
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -449,7 +449,7 @@ static void modem_cmux_on_control_frame(struct modem_cmux *cmux)`
`449`	`449`	`break;`
`450`	`450`
`451`	`451`	`default:`
`452`		`- LOG_WRN("Unknown control frame type");`
	`452`	`+ LOG_WRN("Unknown %s frame type", "control");`
`453`	`453`	`break;`
`454`	`454`	`}`
`455`	`455`	`}`
`@@ -533,7 +533,7 @@ static void modem_cmux_on_dlci_frame(struct modem_cmux *cmux)`
`533`	`533`	`break;`
`534`	`534`
`535`	`535`	`default:`
`536`		`- LOG_WRN("Unknown DLCI frame type");`
	`536`	`+ LOG_WRN("Unknown %s frame type", "DLCI");`
`537`	`537`	`break;`
`538`	`538`	`}`
`539`	`539`	`}`