Skip to content

Commit b4fb530

Browse files
ananglcarlescufi
authored andcommitted
boards: nrf52840dk_nrf52840: Do not enable arduino_serial by default
This is a follow-up to commit 25d7a09. The arduino_serial/uart1 node should not be enabled by default because even if an application does not use it, the default CONFIG_SERIAL=y setting causes that it is anyway initialized, so the UARTE peripheral acquires its assigned pins (and they cannot be used in other way) and its enabled receiver causes increased current consumption (by ~500 uA) when the CPU is sleeping. This affects e.g. the boards/nrf/system_off sample. Applications that actually need to use this UART or shields that use the arduino_serial node should enable the node explicitly. Keep this node disabled by default for the nrf52840dk_nrf52840 board and also for boards whose definitions are mostly copies of the above: nrf52833dk_nrf52833 and nrf21540dk_nrf52840. Update also accordingly a few overlay files in tests/ that were disabling this node because of the pins it undesirably acquired. Signed-off-by: Andrzej Głąbek <[email protected]>
1 parent 96d0773 commit b4fb530

File tree

7 files changed

+0
-20
lines changed

7 files changed

+0
-20
lines changed

boards/arm/nrf21540dk_nrf52840/nrf21540dk_nrf52840.dts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,6 @@
167167
};
168168

169169
arduino_serial: &uart1 {
170-
status = "okay";
171170
current-speed = <115200>;
172171
pinctrl-0 = <&uart1_default>;
173172
pinctrl-1 = <&uart1_sleep>;

boards/arm/nrf52833dk_nrf52833/nrf52833dk_nrf52833.dts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,6 @@
144144
};
145145

146146
arduino_serial: &uart1 {
147-
status = "okay";
148147
current-speed = <115200>;
149148
pinctrl-0 = <&uart1_default>;
150149
pinctrl-1 = <&uart1_sleep>;

boards/arm/nrf52840dk_nrf52840/nrf52840dk_nrf52840.dts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,6 @@
156156
};
157157

158158
arduino_serial: &uart1 {
159-
status = "okay";
160159
current-speed = <115200>;
161160
pinctrl-0 = <&uart1_default>;
162161
pinctrl-1 = <&uart1_sleep>;

tests/drivers/gpio/gpio_basic_api/boards/nrf52840dk_nrf52840.overlay

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,3 @@
1111
in-gpios = <&gpio1 2 0>; /* Arduino D1 */
1212
};
1313
};
14-
15-
&uart1 {
16-
status = "disabled";
17-
};

tests/drivers/i2s/i2s_api/boards/nrf52840dk_nrf52840.overlay

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,6 @@
99
};
1010
};
1111

12-
&uart1 {
13-
status = "disabled";
14-
};
15-
1612
&i2s0 {
1713
status = "okay";
1814
pinctrl-0 = <&i2s0_default_alt>;

tests/drivers/i2s/i2s_speed/boards/nrf52840dk_nrf52840.overlay

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,6 @@
1717
};
1818
};
1919

20-
&uart1 {
21-
status = "disabled";
22-
};
23-
2420
&i2s0 {
2521
status = "okay";
2622
pinctrl-0 = <&i2s0_default_alt>;

tests/drivers/regulator/fixed/boards/nrf52840dk_nrf52840.overlay

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,3 @@
1515
check-gpios = <&gpio1 2 (GPIO_ACTIVE_HIGH | GPIO_PULL_DOWN)>;
1616
};
1717
};
18-
19-
&uart1 {
20-
/* Default-enabled Arduino UART steals the pins we want. */
21-
status = "disabled";
22-
};

0 commit comments

Comments
 (0)