fuel_gauge: composite: fix unreleased PM constraint

JordanYates · JordanYates · commit b71e8193bd68 · 2025-10-09T15:41:56.000+10:00
Fix the PM constraint not being released when the sample fetch API call
fails.

Signed-off-by: Jordan Yates &lt;jordan@embeint.com&gt;
diff --git a/drivers/fuel_gauge/composite/fuel_gauge_composite.c b/drivers/fuel_gauge/composite/fuel_gauge_composite.c
@@ -28,17 +28,19 @@ struct composite_data {
 
 static int composite_fetch(const struct device *dev)
 {
-	int rc;
+	int rc, rc2;
 
 	rc = pm_device_runtime_get(dev);
 	if (rc < 0) {
 		return rc;
 	}
 	rc = sensor_sample_fetch(dev);
-	if (rc < 0) {
-		return rc;
+	/* Uncondionally release the PM constraint */
+	rc2 = pm_device_runtime_put(dev);
+	if (rc == 0) {
+		rc = rc2;
 	}
-	return pm_device_runtime_put(dev);
+	return rc;
 }
 
 static int composite_channel_get(const struct device *dev, enum sensor_channel chan,

Original file line number	Diff line number	Diff line change
`@@ -28,17 +28,19 @@ struct composite_data {`
`28`	`28`
`29`	`29`	`static int composite_fetch(const struct device *dev)`
`30`	`30`	`{`
`31`		`- int rc;`
	`31`	`+ int rc, rc2;`
`32`	`32`
`33`	`33`	`rc = pm_device_runtime_get(dev);`
`34`	`34`	`if (rc < 0) {`
`35`	`35`	`return rc;`
`36`	`36`	`}`
`37`	`37`	`rc = sensor_sample_fetch(dev);`
`38`		`- if (rc < 0) {`
`39`		`- return rc;`
	`38`	`+ /* Uncondionally release the PM constraint */`
	`39`	`+ rc2 = pm_device_runtime_put(dev);`
	`40`	`+ if (rc == 0) {`
	`41`	`+ rc = rc2;`
`40`	`42`	`}`
`41`		`- return pm_device_runtime_put(dev);`
	`43`	`+ return rc;`
`42`	`44`	`}`
`43`	`45`
`44`	`46`	`static int composite_channel_get(const struct device *dev, enum sensor_channel chan,`