drivers: video: Add video_buf_type

ngphibang · ngphibang · commit b76d8695b81c · 2025-05-11T22:59:14.000+02:00
M2M devices like ISPs or PxP have two separate buffer queues, i.e.
incomming and outcomming queues. For each API, the driver needs to
distinguish on which queue it needs to take action.

Add video buffer type to support this kind of devices.

- get_caps(), set/get_format(), enqueue()/dequeue(): the buffer type
is embeded in the video_caps, video_format and video_buffer structs

- video_stream_start/stop() : buffer type needs is sent as a parameter

Signed-off-by: Phi Bang Nguyen &lt;phibang.nguyen@nxp.com&gt;
diff --git a/doc/releases/migration-guide-4.2.rst b/doc/releases/migration-guide-4.2.rst
@@ -503,6 +503,12 @@ Video
 
 * video_endpoint_id enum has been dropped. It is no longer a parameter in any video API.
 
+* video_buf_type enum has been added. It is a required parameter in the following video APIs:
+
+  ``set_stream``
+  ``video_stream_start``
+  ``video_stream_stop``
+
 Other subsystems
 ****************
 
diff --git a/drivers/video/gc2145.c b/drivers/video/gc2145.c
@@ -1093,7 +1093,7 @@ static int gc2145_get_fmt(const struct device *dev, struct video_format *fmt)
 	return 0;
 }
 
-static int gc2145_set_stream(const struct device *dev, bool enable)
+static int gc2145_set_stream(const struct device *dev, bool enable, enum video_buf_type type)
 {
 	const struct gc2145_config *cfg = dev->config;
 
diff --git a/drivers/video/mt9m114.c b/drivers/video/mt9m114.c
@@ -458,7 +458,7 @@ static int mt9m114_get_fmt(const struct device *dev, struct video_format *fmt)
 	return 0;
 }
 
-static int mt9m114_set_stream(const struct device *dev, bool enable)
+static int mt9m114_set_stream(const struct device *dev, bool enable, enum video_buf_type type)
 {
 	return enable ? mt9m114_set_state(dev, MT9M114_SYS_STATE_START_STREAMING)
 		      : mt9m114_set_state(dev, MT9M114_SYS_STATE_ENTER_SUSPEND);
diff --git a/drivers/video/ov2640.c b/drivers/video/ov2640.c
@@ -880,7 +880,7 @@ static int ov2640_get_fmt(const struct device *dev, struct video_format *fmt)
 	return 0;
 }
 
-static int ov2640_set_stream(const struct device *dev, bool enable)
+static int ov2640_set_stream(const struct device *dev, bool enable, enum video_buf_type type)
 {
 	return 0;
 }
diff --git a/drivers/video/ov5640.c b/drivers/video/ov5640.c
@@ -922,7 +922,7 @@ static int ov5640_get_caps(const struct device *dev, struct video_caps *caps)
 	return 0;
 }
 
-static int ov5640_set_stream(const struct device *dev, bool enable)
+static int ov5640_set_stream(const struct device *dev, bool enable, enum video_buf_type type)
 {
 	const struct ov5640_config *cfg = dev->config;
 
diff --git a/drivers/video/ov7670.c b/drivers/video/ov7670.c
@@ -573,7 +573,7 @@ static int ov7670_init(const struct device *dev)
 	return ov7670_init_controls(dev);
 }
 
-static int ov7670_set_stream(const struct device *dev, bool enable)
+static int ov7670_set_stream(const struct device *dev, bool enable, enum video_buf_type type)
 {
 	return 0;
 }
diff --git a/drivers/video/ov7725.c b/drivers/video/ov7725.c
@@ -515,7 +515,7 @@ static int ov7725_get_fmt(const struct device *dev, struct video_format *fmt)
 	return 0;
 }
 
-static int ov7725_set_stream(const struct device *dev, bool enable)
+static int ov7725_set_stream(const struct device *dev, bool enable, enum video_buf_type type)
 {
 	return 0;
 }
diff --git a/drivers/video/video_emul_imager.c b/drivers/video/video_emul_imager.c
@@ -318,7 +318,7 @@ static int emul_imager_get_caps(const struct device *dev, struct video_caps *cap
 	return 0;
 }
 
-static int emul_imager_set_stream(const struct device *dev, bool enable)
+static int emul_imager_set_stream(const struct device *dev, bool enable, enum video_buf_type type)
 {
 	return emul_imager_write_reg(dev, EMUL_IMAGER_REG_CTRL, enable ? 1 : 0);
 }
diff --git a/drivers/video/video_emul_rx.c b/drivers/video/video_emul_rx.c
@@ -86,12 +86,13 @@ static int emul_rx_get_caps(const struct device *dev, struct video_caps *caps)
 	return video_get_caps(cfg->source_dev, caps);
 }
 
-static int emul_rx_set_stream(const struct device *dev, bool enable)
+static int emul_rx_set_stream(const struct device *dev, bool enable, enum video_buf_type type)
 {
 	const struct emul_rx_config *cfg = dev->config;
 
 	/* A real hardware driver would first start / stop its own peripheral */
-	return enable ? video_stream_start(cfg->source_dev) : video_stream_stop(cfg->source_dev);
+	return enable ? video_stream_start(cfg->source_dev, type)
+		      : video_stream_stop(cfg->source_dev, type);
 }
 
 static void emul_rx_worker(struct k_work *work)
diff --git a/drivers/video/video_esp32_dvp.c b/drivers/video/video_esp32_dvp.c
@@ -136,7 +136,7 @@ void video_esp32_dma_rx_done(const struct device *dev, void *user_data, uint32_t
 	video_esp32_reload_dma(data);
 }
 
-static int video_esp32_set_stream(const struct device *dev, bool enable)
+static int video_esp32_set_stream(const struct device *dev, bool enable, enum video_buf_type type)
 {
 	const struct video_esp32_config *cfg = dev->config;
 	struct video_esp32_data *data = dev->data;
@@ -149,7 +149,7 @@ static int video_esp32_set_stream(const struct device *dev, bool enable)
 	if (!enable) {
 		LOG_DBG("Stop streaming");
 
-		if (video_stream_stop(cfg->source_dev)) {
+		if (video_stream_stop(cfg->source_dev, type)) {
 			return -EIO;
 		}
 
@@ -233,7 +233,7 @@ static int video_esp32_set_stream(const struct device *dev, bool enable)
 
 	cam_hal_start_streaming(&data->hal);
 
-	if (video_stream_start(cfg->source_dev)) {
+	if (video_stream_start(cfg->source_dev, type)) {
 		return -EIO;
 	}
 	data->is_streaming = true;
diff --git a/drivers/video/video_mcux_csi.c b/drivers/video/video_mcux_csi.c
@@ -194,7 +194,8 @@ static int video_mcux_csi_get_fmt(const struct device *dev, struct video_format
 	return -EIO;
 }
 
-static int video_mcux_csi_set_stream(const struct device *dev, bool enable)
+static int video_mcux_csi_set_stream(const struct device *dev, bool enable,
+				     enum video_buf_type type)
 {
 	const struct video_mcux_csi_config *config = dev->config;
 	struct video_mcux_csi_data *data = dev->data;
@@ -206,11 +207,11 @@ static int video_mcux_csi_set_stream(const struct device *dev, bool enable)
 			return -EIO;
 		}
 
-		if (config->source_dev && video_stream_start(config->source_dev)) {
+		if (config->source_dev && video_stream_start(config->source_dev, type)) {
 			return -EIO;
 		}
 	} else {
-		if (config->source_dev && video_stream_stop(config->source_dev)) {
+		if (config->source_dev && video_stream_stop(config->source_dev, type)) {
 			return -EIO;
 		}
 
diff --git a/drivers/video/video_mcux_mipi_csi2rx.c b/drivers/video/video_mcux_mipi_csi2rx.c
@@ -141,19 +141,19 @@ static int mipi_csi2rx_get_fmt(const struct device *dev, struct video_format *fm
 	return 0;
 }
 
-static int mipi_csi2rx_set_stream(const struct device *dev, bool enable)
+static int mipi_csi2rx_set_stream(const struct device *dev, bool enable, enum video_buf_type type)
 {
 	const struct mipi_csi2rx_config *config = dev->config;
 
 	if (enable) {
 		struct mipi_csi2rx_data *drv_data = dev->data;
 
 		CSI2RX_Init((MIPI_CSI2RX_Type *)config->base, &drv_data->csi2rxConfig);
-		if (video_stream_start(config->sensor_dev)) {
+		if (video_stream_start(config->sensor_dev, type)) {
 			return -EIO;
 		}
 	} else {
-		if (video_stream_stop(config->sensor_dev)) {
+		if (video_stream_stop(config->sensor_dev, type)) {
 			return -EIO;
 		}
 		CSI2RX_Deinit((MIPI_CSI2RX_Type *)config->base);
diff --git a/drivers/video/video_mcux_smartdma.c b/drivers/video/video_mcux_smartdma.c
@@ -95,7 +95,8 @@ static void nxp_video_sdma_callback(const struct device *dev, void *user_data,
 	data->buf_reload_flag = !data->buf_reload_flag;
 }
 
-static int nxp_video_sdma_set_stream(const struct device *dev, bool enable)
+static int nxp_video_sdma_set_stream(const struct device *dev, bool enable,
+				     enum video_buf_type type)
 {
 	const struct nxp_video_sdma_config *config = dev->config;
 	struct nxp_video_sdma_data *data = dev->data;
@@ -162,7 +163,7 @@ static int nxp_video_sdma_enqueue(const struct device *dev, struct video_buffer
 	k_fifo_put(&data->fifo_in, vbuf);
 	if (data->stream_starved) {
 		/* Kick SmartDMA off */
-		nxp_video_sdma_set_stream(dev, true);
+		nxp_video_sdma_set_stream(dev, true, vbuf->type);
 	}
 	return 0;
 }
diff --git a/drivers/video/video_stm32_dcmi.c b/drivers/video/video_stm32_dcmi.c
@@ -244,14 +244,15 @@ static int video_stm32_dcmi_get_fmt(const struct device *dev, struct video_forma
 	return 0;
 }
 
-static int video_stm32_dcmi_set_stream(const struct device *dev, bool enable)
+static int video_stm32_dcmi_set_stream(const struct device *dev, bool enable,
+				       enum video_buf_type type)
 {
 	int err;
 	struct video_stm32_dcmi_data *data = dev->data;
 	const struct video_stm32_dcmi_config *config = dev->config;
 
 	if (!enable) {
-		if (video_stream_stop(config->sensor_dev)) {
+		if (video_stream_stop(config->sensor_dev, type)) {
 			return -EIO;
 		}
 
@@ -281,7 +282,7 @@ static int video_stm32_dcmi_set_stream(const struct device *dev, bool enable)
 		return -EIO;
 	}
 
-	if (video_stream_start(config->sensor_dev)) {
+	if (video_stream_start(config->sensor_dev, type)) {
 		return -EIO;
 	}
 
diff --git a/drivers/video/video_sw_generator.c b/drivers/video/video_sw_generator.c
@@ -95,7 +95,8 @@ static int video_sw_generator_get_fmt(const struct device *dev, struct video_for
 	return 0;
 }
 
-static int video_sw_generator_set_stream(const struct device *dev, bool enable)
+static int video_sw_generator_set_stream(const struct device *dev, bool enable,
+					 enum video_buf_type type)
 {
 	struct video_sw_generator_data *data = dev->data;
 
diff --git a/include/zephyr/drivers/video.h b/include/zephyr/drivers/video.h
@@ -40,13 +40,30 @@ extern "C" {
 
 struct video_control;
 
+/**
+ * @brief video_buf_type enum
+ *
+ * Supported video buffer types of a video device.
+ * The direction (input or output) is defined from the device's point of view.
+ * Devices like cameras support only output type, encoders support only input
+ * types while m2m devices like ISP, PxP support both input and output types.
+ */
+enum video_buf_type {
+	/** input buffer type */
+	VIDEO_BUF_TYPE_INPUT,
+	/** output buffer type */
+	VIDEO_BUF_TYPE_OUTPUT,
+};
+
 /**
  * @struct video_format
  * @brief Video format structure
  *
  * Used to configure frame format.
  */
 struct video_format {
+	/** type of the buffer */
+	enum video_buf_type type;
 	/** FourCC pixel format value (\ref video_pixel_formats) */
 	uint32_t pixelformat;
 	/** frame width in pixels. */
@@ -93,6 +110,8 @@ struct video_format_cap {
  * Used to describe video endpoint capabilities.
  */
 struct video_caps {
+	/** type of the buffer */
+	enum video_buf_type type;
 	/** list of video format capabilities (zero terminated). */
 	const struct video_format_cap *format_caps;
 	/** minimal count of video buffers to enqueue before being able to start
@@ -124,6 +143,8 @@ struct video_caps {
  * Represent a video frame.
  */
 struct video_buffer {
+	/** type of the buffer */
+	enum video_buf_type type;
 	/** pointer to driver specific data. */
 	void *driver_data;
 	/** pointer to the start of the buffer. */
@@ -289,11 +310,13 @@ typedef int (*video_api_flush_t)(const struct device *dev, bool cancel);
  * Start (enable == true) or stop (enable == false) streaming on the video device.
  *
  * @param dev Pointer to the device structure.
+ * @param type The type of the buffers stream to start or stop.
  * @param enable If true, start streaming, otherwise stop streaming.
  *
  * @retval 0 on success, otherwise a negative errno code.
  */
-typedef int (*video_api_set_stream_t)(const struct device *dev, bool enable);
+typedef int (*video_api_set_stream_t)(const struct device *dev, bool enable,
+				      enum video_buf_type type);
 
 /**
  * @typedef video_api_ctrl_t
@@ -545,18 +568,21 @@ static inline int video_flush(const struct device *dev, bool cancel)
  * able to start streaming, then driver set the min_vbuf_count to the related
  * endpoint capabilities.
  *
+ * @param dev Pointer to the device structure.
+ * @param type The type of the buffers stream to start.
+ *
  * @retval 0 Is successful.
  * @retval -EIO General input / output error.
  */
-static inline int video_stream_start(const struct device *dev)
+static inline int video_stream_start(const struct device *dev, enum video_buf_type type)
 {
 	const struct video_driver_api *api = (const struct video_driver_api *)dev->api;
 
 	if (api->set_stream == NULL) {
 		return -ENOSYS;
 	}
 
-	return api->set_stream(dev, true);
+	return api->set_stream(dev, true, type);
 }
 
 /**
@@ -565,10 +591,13 @@ static inline int video_stream_start(const struct device *dev)
  * On video_stream_stop, driver must stop any transactions or wait until they
  * finish.
  *
+ * @param dev Pointer to the device structure.
+ * @param type The type of the buffers stream to stop.
+ *
  * @retval 0 Is successful.
  * @retval -EIO General input / output error.
  */
-static inline int video_stream_stop(const struct device *dev)
+static inline int video_stream_stop(const struct device *dev, enum video_buf_type type)
 {
 	const struct video_driver_api *api = (const struct video_driver_api *)dev->api;
 	int ret;
@@ -577,7 +606,7 @@ static inline int video_stream_stop(const struct device *dev)
 		return -ENOSYS;
 	}
 
-	ret = api->set_stream(dev, false);
+	ret = api->set_stream(dev, false, type);
 	video_flush(dev, true);
 
 	return ret;
diff --git a/samples/drivers/video/capture/src/main.c b/samples/drivers/video/capture/src/main.c
@@ -243,7 +243,7 @@ int main(void)
 	}
 
 	/* Start video capture */
-	if (video_stream_start(video_dev)) {
+	if (video_stream_start(video_dev, VIDEO_BUF_TYPE_OUTPUT)) {
 		LOG_ERR("Unable to start capture (interface)");
 		return 0;
 	}
diff --git a/samples/drivers/video/capture_to_lvgl/src/main.c b/samples/drivers/video/capture_to_lvgl/src/main.c
@@ -119,7 +119,7 @@ int main(void)
 	}
 
 	/* Start video capture */
-	if (video_stream_start(video_dev)) {
+	if (video_stream_start(video_dev, VIDEO_BUF_TYPE_OUTPUT)) {
 		LOG_ERR("Unable to start capture (interface)");
 		return 0;
 	}
diff --git a/samples/drivers/video/tcpserversink/src/main.c b/samples/drivers/video/tcpserversink/src/main.c
@@ -129,7 +129,7 @@ int main(void)
 		}
 
 		/* Start video capture */
-		if (video_stream_start(video)) {
+		if (video_stream_start(video, VIDEO_BUF_TYPE_OUTPUT)) {
 			LOG_ERR("Unable to start video");
 			return 0;
 		}
@@ -159,7 +159,7 @@ int main(void)
 		} while (!ret);
 
 		/* stop capture */
-		if (video_stream_stop(video)) {
+		if (video_stream_stop(video, VIDEO_BUF_TYPE_OUTPUT)) {
 			LOG_ERR("Unable to stop video");
 			return 0;
 		}
diff --git a/tests/drivers/video/api/src/video_emul.c b/tests/drivers/video/api/src/video_emul.c
@@ -16,11 +16,11 @@ ZTEST(video_common, test_video_device)
 	zexpect_true(device_is_ready(rx_dev));
 	zexpect_true(device_is_ready(imager_dev));
 
-	zexpect_ok(video_stream_start(imager_dev));
-	zexpect_ok(video_stream_stop(imager_dev));
+	zexpect_ok(video_stream_start(imager_dev, VIDEO_BUF_TYPE_OUTPUT));
+	zexpect_ok(video_stream_stop(imager_dev, VIDEO_BUF_TYPE_OUTPUT));
 
-	zexpect_ok(video_stream_start(rx_dev));
-	zexpect_ok(video_stream_stop(rx_dev));
+	zexpect_ok(video_stream_start(rx_dev, VIDEO_BUF_TYPE_OUTPUT));
+	zexpect_ok(video_stream_stop(rx_dev, VIDEO_BUF_TYPE_OUTPUT));
 }
 
 ZTEST(video_common, test_video_format)
@@ -157,7 +157,7 @@ ZTEST(video_common, test_video_vbuf)
 	zexpect_not_null(vbuf);
 
 	/* Start the virtual hardware */
-	zexpect_ok(video_stream_start(rx_dev));
+	zexpect_ok(video_stream_start(rx_dev, VIDEO_BUF_TYPE_OUTPUT));
 
 	/* Enqueue a first buffer */
 	zexpect_ok(video_enqueue(rx_dev, vbuf));

Original file line number	Diff line number	Diff line change
`@@ -1093,7 +1093,7 @@ static int gc2145_get_fmt(const struct device dev, struct video_format fmt)`
`1093`	`1093`	`return 0;`
`1094`	`1094`	`}`
`1095`	`1095`
`1096`		`-static int gc2145_set_stream(const struct device *dev, bool enable)`
	`1096`	`+static int gc2145_set_stream(const struct device *dev, bool enable, enum video_buf_type type)`
`1097`	`1097`	`{`
`1098`	`1098`	`const struct gc2145_config *cfg = dev->config;`
`1099`	`1099`
Original file line number	Diff line number	Diff line change
`@@ -458,7 +458,7 @@ static int mt9m114_get_fmt(const struct device dev, struct video_format fmt)`
`458`	`458`	`return 0;`
`459`	`459`	`}`
`460`	`460`
`461`		`-static int mt9m114_set_stream(const struct device *dev, bool enable)`
	`461`	`+static int mt9m114_set_stream(const struct device *dev, bool enable, enum video_buf_type type)`
`462`	`462`	`{`
`463`	`463`	`return enable ? mt9m114_set_state(dev, MT9M114_SYS_STATE_START_STREAMING)`
`464`	`464`	`: mt9m114_set_state(dev, MT9M114_SYS_STATE_ENTER_SUSPEND);`
Original file line number	Diff line number	Diff line change
`@@ -880,7 +880,7 @@ static int ov2640_get_fmt(const struct device dev, struct video_format fmt)`
`880`	`880`	`return 0;`
`881`	`881`	`}`
`882`	`882`
`883`		`-static int ov2640_set_stream(const struct device *dev, bool enable)`
	`883`	`+static int ov2640_set_stream(const struct device *dev, bool enable, enum video_buf_type type)`
`884`	`884`	`{`
`885`	`885`	`return 0;`
`886`	`886`	`}`
Original file line number	Diff line number	Diff line change
`@@ -922,7 +922,7 @@ static int ov5640_get_caps(const struct device dev, struct video_caps caps)`
`922`	`922`	`return 0;`
`923`	`923`	`}`
`924`	`924`
`925`		`-static int ov5640_set_stream(const struct device *dev, bool enable)`
	`925`	`+static int ov5640_set_stream(const struct device *dev, bool enable, enum video_buf_type type)`
`926`	`926`	`{`
`927`	`927`	`const struct ov5640_config *cfg = dev->config;`
`928`	`928`
Original file line number	Diff line number	Diff line change
`@@ -573,7 +573,7 @@ static int ov7670_init(const struct device *dev)`
`573`	`573`	`return ov7670_init_controls(dev);`
`574`	`574`	`}`
`575`	`575`
`576`		`-static int ov7670_set_stream(const struct device *dev, bool enable)`
	`576`	`+static int ov7670_set_stream(const struct device *dev, bool enable, enum video_buf_type type)`
`577`	`577`	`{`
`578`	`578`	`return 0;`
`579`	`579`	`}`
Original file line number	Diff line number	Diff line change
`@@ -515,7 +515,7 @@ static int ov7725_get_fmt(const struct device dev, struct video_format fmt)`
`515`	`515`	`return 0;`
`516`	`516`	`}`
`517`	`517`
`518`		`-static int ov7725_set_stream(const struct device *dev, bool enable)`
	`518`	`+static int ov7725_set_stream(const struct device *dev, bool enable, enum video_buf_type type)`
`519`	`519`	`{`
`520`	`520`	`return 0;`
`521`	`521`	`}`
Original file line number	Diff line number	Diff line change
`@@ -318,7 +318,7 @@ static int emul_imager_get_caps(const struct device dev, struct video_caps cap`
`318`	`318`	`return 0;`
`319`	`319`	`}`
`320`	`320`
`321`		`-static int emul_imager_set_stream(const struct device *dev, bool enable)`
	`321`	`+static int emul_imager_set_stream(const struct device *dev, bool enable, enum video_buf_type type)`
`322`	`322`	`{`
`323`	`323`	`return emul_imager_write_reg(dev, EMUL_IMAGER_REG_CTRL, enable ? 1 : 0);`
`324`	`324`	`}`
Original file line number	Diff line number	Diff line change
`@@ -86,12 +86,13 @@ static int emul_rx_get_caps(const struct device dev, struct video_caps caps)`
`86`	`86`	`return video_get_caps(cfg->source_dev, caps);`
`87`	`87`	`}`
`88`	`88`
`89`		`-static int emul_rx_set_stream(const struct device *dev, bool enable)`
	`89`	`+static int emul_rx_set_stream(const struct device *dev, bool enable, enum video_buf_type type)`
`90`	`90`	`{`
`91`	`91`	`const struct emul_rx_config *cfg = dev->config;`
`92`	`92`
`93`	`93`	`/* A real hardware driver would first start / stop its own peripheral */`
`94`		`- return enable ? video_stream_start(cfg->source_dev) : video_stream_stop(cfg->source_dev);`
	`94`	`+ return enable ? video_stream_start(cfg->source_dev, type)`
	`95`	`+ : video_stream_stop(cfg->source_dev, type);`
`95`	`96`	`}`
`96`	`97`
`97`	`98`	`static void emul_rx_worker(struct k_work *work)`
Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ void video_esp32_dma_rx_done(const struct device dev, void user_data, uint32_t`
`136`	`136`	`video_esp32_reload_dma(data);`
`137`	`137`	`}`
`138`	`138`
`139`		`-static int video_esp32_set_stream(const struct device *dev, bool enable)`
	`139`	`+static int video_esp32_set_stream(const struct device *dev, bool enable, enum video_buf_type type)`
`140`	`140`	`{`
`141`	`141`	`const struct video_esp32_config *cfg = dev->config;`
`142`	`142`	`struct video_esp32_data *data = dev->data;`
`@@ -149,7 +149,7 @@ static int video_esp32_set_stream(const struct device *dev, bool enable)`
`149`	`149`	`if (!enable) {`
`150`	`150`	`LOG_DBG("Stop streaming");`
`151`	`151`
`152`		`- if (video_stream_stop(cfg->source_dev)) {`
	`152`	`+ if (video_stream_stop(cfg->source_dev, type)) {`
`153`	`153`	`return -EIO;`
`154`	`154`	`}`
`155`	`155`
`@@ -233,7 +233,7 @@ static int video_esp32_set_stream(const struct device *dev, bool enable)`
`233`	`233`
`234`	`234`	`cam_hal_start_streaming(&data->hal);`
`235`	`235`
`236`		`- if (video_stream_start(cfg->source_dev)) {`
	`236`	`+ if (video_stream_start(cfg->source_dev, type)) {`
`237`	`237`	`return -EIO;`
`238`	`238`	`}`
`239`	`239`	`data->is_streaming = true;`