drivers: video: ov5640: support DVP bus-width and data-shift from DTS

Add support in the OV5640 driver to configure the bus-width and
data-shift properties from devicetree when operating in DVP
(parallel) mode.

This allows the number of parallel data lines and the bit shift
to be set directly via DTS, ensuring correct configuration across
different hardware designs.

Signed-off-by: Khanh Nguyen <[email protected]>

Author: KhanhNguyen-RVC

drivers/video/ov5640.c

@@ -95,6 +95,8 @@ LOG_MODULE_REGISTER(video_ov5640, CONFIG_VIDEO_LOG_LEVEL);
 #define SDE_CTRL10_REG 0x558a
 #define SDE_CTRL11_REG 0x558b
 
+#define DATA_ORDER_REG 0x4745
+
 #define DEFAULT_MIPI_CHANNEL 0
 
 #define PI 3.141592654
@@ -124,6 +126,8 @@ struct ov5640_config {
 	struct gpio_dt_spec powerdown_gpio;
 #endif
 	int bus_type;
+	int bus_width;
+	int data_shift;
 };
 
 struct ov5640_reg {
@@ -1394,6 +1398,33 @@ static int ov5640_init(const struct device *dev)
 			LOG_ERR("Unable to initialize the sensor with DVP parameters");
 			return -EIO;
 		}
+
+		/*
+		 * Select the DVP data order using bits [2:1] of DATA_ORDER_REG:
+		 * 00: 10-bit bus, Data[9:0]
+		 * 10: 8-bit bus, Data[7:0]
+		 * x1: 8-bit bus, Data[9:2]
+		 */
+		uint8_t data_order = 0;
+
+		if (cfg->bus_width == 8 && cfg->data_shift == 0) {
+			data_order = BIT(2);
+		} else if (cfg->bus_width == 8 && cfg->data_shift == 2) {
+			data_order = BIT(1);
+		} else if (cfg->bus_width == 10 && cfg->data_shift == 0) {
+			data_order = 0;
+		} else {
+			LOG_ERR("Invalid DVP data order: bus width = %u, data shift = %u",
+				cfg->bus_width, cfg->data_shift);
+			return -EIO;
+		}
+
+		/* Set DVP data order */
+		ret = ov5640_modify_reg(&cfg->i2c, DATA_ORDER_REG, BIT(2) | BIT(1), data_order);
+		if (ret) {
+			LOG_ERR("Unable to set DVP data order");
+			return -EIO;
+		}
 	} else {
 		/* Set virtual channel */
 		ret = ov5640_modify_reg(&cfg->i2c, 0x4814, 3U << 6,
@@ -1451,16 +1482,18 @@ static int ov5640_init(const struct device *dev)
 #define OV5640_GET_POWERDOWN_GPIO(n)
 #endif
 
+#define OV5640_EP_PROP_OR(n, prop, default)                                                        \
+	DT_PROP_OR(DT_CHILD(DT_INST_CHILD(n, port), endpoint), prop, default)
+
 #define OV5640_INIT(n)                                                                             \
 	static struct ov5640_data ov5640_data_##n;                                                 \
                                                                                                    \
 	static const struct ov5640_config ov5640_cfg_##n = {                                       \
 		.i2c = I2C_DT_SPEC_INST_GET(n),                                                    \
-		OV5640_GET_RESET_GPIO(n)							   \
-		OV5640_GET_POWERDOWN_GPIO(n)							   \
-		.bus_type = DT_PROP_OR(DT_CHILD(DT_INST_CHILD(n, port), endpoint), bus_type,       \
-				       VIDEO_BUS_TYPE_CSI2_DPHY),                                  \
-	};                                                                                         \
+		.bus_type = OV5640_EP_PROP_OR(n, bus_type, VIDEO_BUS_TYPE_CSI2_DPHY),              \
+		.bus_width = OV5640_EP_PROP_OR(n, bus_width, 10),                                  \
+		.data_shift = OV5640_EP_PROP_OR(n, data_shift, 0),                                 \
+		OV5640_GET_RESET_GPIO(n) OV5640_GET_POWERDOWN_GPIO(n)};                            \
                                                                                                    \
 	DEVICE_DT_INST_DEFINE(n, &ov5640_init, NULL, &ov5640_data_##n, &ov5640_cfg_##n,            \
 			      POST_KERNEL, CONFIG_VIDEO_INIT_PRIORITY, &ov5640_driver_api);        \

dts/bindings/video/ovti,ov5640.yaml

@@ -22,3 +22,19 @@ properties:
 child-binding:
   child-binding:
     include: video-interfaces.yaml
+
+    properties:
+      bus-width:
+        enum: [8, 10]
+        description: |
+          Number of parallel data lines for pixel output. The OV5640
+          supports only 8-bit or 10-bit configurations. This property
+          is valid only for parallel buses.
+
+      data-shift:
+        enum: [0, 2]
+        description: |
+          Bit shift applied to the parallel data lines. The OV5640
+          supports only 0 (no shift) or 2-bit shift. For example:
+            - "bus-width = <8>; data-shift = <0>;" lines 7:0 are used
+            - "bus-width = <8>; data-shift = <2>;" lines 9:2 are used