bugfix: esp32: spi: correct idle polarity and mode configuration

Martin Kiepfer · carlescufi · commit bda6656eca29 · 2023-08-29T10:25:45.000+02:00
Possible fix for incorrection spi mode configuration on esp32 (#61866) Signed-off-by: Martin Kiepfer <mrmarteng@teleschirm.org>
diff --git a/drivers/spi/spi_esp32_spim.c b/drivers/spi/spi_esp32_spim.c
@@ -331,11 +331,10 @@ static int IRAM_ATTR spi_esp32_configure(const struct device *dev,
 
 	/* SPI mode */
 	hal_dev->mode = 0;
-	if (SPI_MODE_GET(spi_cfg->operation) & SPI_MODE_CPOL) {
+	if (SPI_MODE_GET(spi_cfg->operation) & SPI_MODE_CPHA) {
 		hal_dev->mode = BIT(0);
 	}
-
-	if (SPI_MODE_GET(spi_cfg->operation) & SPI_MODE_CPHA) {
+	if (SPI_MODE_GET(spi_cfg->operation) & SPI_MODE_CPOL) {
 		hal_dev->mode |= BIT(1);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -331,11 +331,10 @@ static int IRAM_ATTR spi_esp32_configure(const struct device *dev,`
`331`	`331`
`332`	`332`	`/* SPI mode */`
`333`	`333`	`hal_dev->mode = 0;`
`334`		`- if (SPI_MODE_GET(spi_cfg->operation) & SPI_MODE_CPOL) {`
	`334`	`+ if (SPI_MODE_GET(spi_cfg->operation) & SPI_MODE_CPHA) {`
`335`	`335`	`hal_dev->mode = BIT(0);`
`336`	`336`	`}`
`337`		`-`
`338`		`- if (SPI_MODE_GET(spi_cfg->operation) & SPI_MODE_CPHA) {`
	`337`	`+ if (SPI_MODE_GET(spi_cfg->operation) & SPI_MODE_CPOL) {`
`339`	`338`	`hal_dev->mode \|= BIT(1);`
`340`	`339`	`}`
`341`	`340`