drivers: gpio: Use BIT(n) macro to define GPIO constants

This change would also solve that according to the C11 standard,
section 6.5, paragraph 4, the usage of bitwise operators on
signed integers is implementation defined.

Signed-off-by: Stephan Gatzka <[email protected]>

Author: gatzka

drivers/gpio/gpio_emul.c

@@ -249,7 +249,7 @@ static void gpio_emul_gen_interrupt_bits(const struct device *port,
 		case GPIO_INT_DISABLE:
 			break;
 		default:
-			LOG_DBG("unhandled case %u",
+			LOG_DBG("unhandled case %lu",
 				drv_data->flags[i] & GPIO_EMUL_INT_BITMASK);
 			break;
 		}

include/zephyr/drivers/gpio.h

@@ -45,24 +45,24 @@ extern "C" {
  */
 
 /** Enables pin as input. */
-#define GPIO_INPUT              (1U << 16)
+#define GPIO_INPUT              BIT(16)
 
 /** Enables pin as output, no change to the output state. */
-#define GPIO_OUTPUT             (1U << 17)
+#define GPIO_OUTPUT             BIT(17)
 
 /** Disables pin for both input and output. */
 #define GPIO_DISCONNECTED	0
 
 /** @cond INTERNAL_HIDDEN */
 
 /* Initializes output to a low state. */
-#define GPIO_OUTPUT_INIT_LOW    (1U << 18)
+#define GPIO_OUTPUT_INIT_LOW    BIT(18)
 
 /* Initializes output to a high state. */
-#define GPIO_OUTPUT_INIT_HIGH   (1U << 19)
+#define GPIO_OUTPUT_INIT_HIGH   BIT(19)
 
 /* Initializes output based on logic level */
-#define GPIO_OUTPUT_INIT_LOGICAL (1U << 20)
+#define GPIO_OUTPUT_INIT_LOGICAL BIT(20)
 
 /** @endcond */
 
@@ -98,19 +98,19 @@ extern "C" {
  */
 
 /** Disables GPIO pin interrupt. */
-#define GPIO_INT_DISABLE               (1U << 21)
+#define GPIO_INT_DISABLE               BIT(21)
 
 /** @cond INTERNAL_HIDDEN */
 
 /* Enables GPIO pin interrupt. */
-#define GPIO_INT_ENABLE                (1U << 22)
+#define GPIO_INT_ENABLE                BIT(22)
 
 /* GPIO interrupt is sensitive to logical levels.
  *
  * This is a component flag that should be combined with other
  * `GPIO_INT_*` flags to produce a meaningful configuration.
  */
-#define GPIO_INT_LEVELS_LOGICAL        (1U << 23)
+#define GPIO_INT_LEVELS_LOGICAL        BIT(23)
 
 /* GPIO interrupt is edge sensitive.
  *
@@ -119,23 +119,23 @@ extern "C" {
  * This is a component flag that should be combined with other
  * `GPIO_INT_*` flags to produce a meaningful configuration.
  */
-#define GPIO_INT_EDGE                  (1U << 24)
+#define GPIO_INT_EDGE                  BIT(24)
 
 /* Trigger detection when input state is (or transitions to) physical low or
  * logical 0 level.
  *
  * This is a component flag that should be combined with other
  * `GPIO_INT_*` flags to produce a meaningful configuration.
  */
-#define GPIO_INT_LOW_0                 (1U << 25)
+#define GPIO_INT_LOW_0                 BIT(25)
 
 /* Trigger detection on input state is (or transitions to) physical high or
  * logical 1 level.
  *
  * This is a component flag that should be combined with other
  * `GPIO_INT_*` flags to produce a meaningful configuration.
  */
-#define GPIO_INT_HIGH_1                (1U << 26)
+#define GPIO_INT_HIGH_1                BIT(26)
 
 #ifdef CONFIG_GPIO_ENABLE_DISABLE_INTERRUPT
 /* Disable/Enable interrupt functionality without changing other interrupt
@@ -144,7 +144,7 @@ extern "C" {
  * This is a component flag that should be combined with `GPIO_INT_ENABLE` or
  * `GPIO_INT_DISABLE` flags to produce a meaningful configuration.
  */
-#define GPIO_INT_ENABLE_DISABLE_ONLY   (1u << 27)
+#define GPIO_INT_ENABLE_DISABLE_ONLY   BIT(27)
 #endif /* CONFIG_GPIO_ENABLE_DISABLE_INTERRUPT */
 
 #define GPIO_INT_MASK                  (GPIO_INT_DISABLE | \

samples/drivers/lcd_hd44780/src/main.c

@@ -148,7 +148,7 @@
 #define GPIO_PIN_CFG(dev, pin, dir)						\
 	do {									\
 		if (gpio_pin_configure((dev), (pin), (dir))) {			\
-			printk("Err cfg " GPIO_NAME "%d! %x\n", (pin), (dir));	\
+			printk("Err cfg " GPIO_NAME "%d! %lx\n", (pin), (dir));	\
 		}								\
 	} while (0)