Skip to content

Commit c75fadb

Browse files
drivers: wifi: siwx917: Set security configuration to default
- Updated Wi-Fi security configuration to use default, allowing the device to select the best available encryption. - Removed unsupported security features. - Replaced `WIFI_SECURITY_TYPE_SAE` with `WIFI_SECURITY_TYPE_SAE_AUTO` to enable automatic selection between SAE-HNP and SAE-H2E, as the device supports both modes by default. Signed-off-by: Arunmani Alagarsamy <[email protected]>
1 parent 7e18f80 commit c75fadb

File tree

1 file changed

+10
-17
lines changed

1 file changed

+10
-17
lines changed

drivers/wifi/siwx91x/siwx91x_wifi.c

Lines changed: 10 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -51,38 +51,31 @@ static int siwx91x_connect(const struct device *dev, struct wifi_connect_req_par
5151
{
5252
sl_wifi_client_configuration_t wifi_config = {
5353
.bss_type = SL_WIFI_BSS_TYPE_INFRASTRUCTURE,
54+
.encryption = SL_WIFI_DEFAULT_ENCRYPTION,
55+
.credential_id = SL_NET_DEFAULT_WIFI_CLIENT_CREDENTIAL_ID,
5456
};
5557
int ret;
5658

5759
switch (params->security) {
5860
case WIFI_SECURITY_TYPE_NONE:
5961
wifi_config.security = SL_WIFI_OPEN;
60-
wifi_config.encryption = SL_WIFI_NO_ENCRYPTION;
6162
break;
6263
case WIFI_SECURITY_TYPE_WPA_PSK:
6364
wifi_config.security = SL_WIFI_WPA;
64-
wifi_config.encryption = SL_WIFI_DEFAULT_ENCRYPTION;
65-
wifi_config.credential_id = SL_NET_DEFAULT_WIFI_CLIENT_CREDENTIAL_ID;
6665
break;
6766
case WIFI_SECURITY_TYPE_PSK:
68-
wifi_config.security = SL_WIFI_WPA2;
69-
wifi_config.encryption = SL_WIFI_TKIP_ENCRYPTION;
70-
wifi_config.credential_id = SL_NET_DEFAULT_WIFI_CLIENT_CREDENTIAL_ID;
71-
break;
67+
/* This case is meant to fall through to the next */
7268
case WIFI_SECURITY_TYPE_PSK_SHA256:
69+
/* Use WPA2 security as the device supports only SHA256
70+
* key derivation for WPA2-PSK
71+
*/
7372
wifi_config.security = SL_WIFI_WPA2;
74-
wifi_config.encryption = SL_WIFI_CCMP_ENCRYPTION;
75-
wifi_config.credential_id = SL_NET_DEFAULT_WIFI_CLIENT_CREDENTIAL_ID;
7673
break;
77-
case WIFI_SECURITY_TYPE_SAE:
78-
/* TODO: Support the case where MFP is not required */
74+
case WIFI_SECURITY_TYPE_SAE_AUTO:
75+
/* Use WPA3 security as the device supports only HNP and H2E
76+
* methods for SAE
77+
*/
7978
wifi_config.security = SL_WIFI_WPA3;
80-
wifi_config.credential_id = SL_NET_DEFAULT_WIFI_CLIENT_CREDENTIAL_ID;
81-
break;
82-
case WIFI_SECURITY_TYPE_WPA_AUTO_PERSONAL:
83-
wifi_config.security = SL_WIFI_WPA2;
84-
wifi_config.encryption = SL_WIFI_DEFAULT_ENCRYPTION;
85-
wifi_config.credential_id = SL_NET_DEFAULT_WIFI_CLIENT_CREDENTIAL_ID;
8679
break;
8780
/* Zephyr WiFi shell doesn't specify how to pass credential for these
8881
* key managements.

0 commit comments

Comments
 (0)