drivers: ethernet phy_dm8806_read_reg reduce nested-ifs

reduce if nesting a bit using early break

Signed-off-by: Jilay Pandya <[email protected]>

Author: jilaypandya

drivers/ethernet/phy/phy_dm8806.c

@@ -146,7 +146,7 @@ static int phy_dm8806_write_reg(const struct device *dev, uint8_t phyad, uint8_t
 					repetition);
 				if (repetition >= CONFIG_PHY_DM8806_SMI_BUS_CHECK_REPETITION) {
 					LOG_ERR("Maximum number of PHY write repetition exceed.");
-					res = (-EIO);
+					res = -EIO;
 				}
 			} else {
 				break;
@@ -158,7 +158,7 @@ static int phy_dm8806_write_reg(const struct device *dev, uint8_t phyad, uint8_t
 		} else {
 			if (checksum_mismatch) {
 				LOG_ERR("Wrong checksum, during PHY write procedure.");
-				res = (-EIO);
+				res = -EIO;
 				break;
 			}
 		}
@@ -217,20 +217,18 @@ static int phy_dm8806_read_reg(const struct device *dev, uint8_t phyad, uint8_t
 
 		if (CONFIG_PHY_DM8806_SMI_BUS_CHECK_REPETITION > 0) {
 			repetition++;
-			if (hw_checksum != sw_checksum) {
-				LOG_WRN("%d repeat of PHY read procedure due to checksum error.",
-					repetition);
-				if (repetition >= CONFIG_PHY_DM8806_SMI_BUS_CHECK_REPETITION) {
-					LOG_ERR("Maximum number of PHY read repetition exceed.");
-					res = (-EIO);
-				}
-			} else {
+			if (hw_checksum == sw_checksum) {
 				break;
 			}
+			LOG_WRN("%d repeat PHY read procedure due to checksum error.", repetition);
+			if (repetition >= CONFIG_PHY_DM8806_SMI_BUS_CHECK_REPETITION) {
+				LOG_ERR("Maximum number of PHY read repetition exceed.");
+				res = -EIO;
+			}
 		} else {
 			if (hw_checksum != sw_checksum) {
 				LOG_ERR("Wrong checksum, during PHY read procedure.");
-				res = (-EIO);
+				res = -EIO;
 				break;
 			}
 		}
@@ -335,14 +333,14 @@ int phy_dm8806_init_interrupt(const struct device *dev)
 	 */
 	res = mdio_read(cfg->mdio, DM8806_INT_MASK_CTRL_PHY_ADDR, DM8806_INT_MASK_CTRL_REG_ADDR,
 			&data);
-	if (res) {
+	if (res < 0) {
 		LOG_ERR("Failed to read IRQ_LED_CONTROL, %i", res);
 		return res;
 	}
 	data |= 0x1;
 	res = mdio_write(cfg->mdio, DM8806_INT_MASK_CTRL_PHY_ADDR, DM8806_INT_MASK_CTRL_REG_ADDR,
 			 data);
-	if (res) {
+	if (res < 0) {
 		LOG_ERR("Failed to read IRQ_LED_CONTROL, %i", res);
 		return res;
 	}
@@ -352,14 +350,14 @@ int phy_dm8806_init_interrupt(const struct device *dev)
 	 */
 	res = mdio_read(cfg->mdio, DM8806_WOLL_CTRL_REG_PHY_ADDR, DM8806_WOLL_CTRL_REG_REG_ADDR,
 			&data);
-	if (res) {
+	if (res < 0) {
 		LOG_ERR("Failed to read IRQ_LED_CONTROL, %i", res);
 		return res;
 	}
 	data |= 0xF;
 	res = mdio_write(cfg->mdio, DM8806_WOLL_CTRL_REG_PHY_ADDR, DM8806_WOLL_CTRL_REG_REG_ADDR,
 			 data);
-	if (res) {
+	if (res < 0) {
 		LOG_ERR("Failed to read IRQ_LED_CONTROL, %i", res);
 		return res;
 	}
@@ -634,7 +632,7 @@ static int phy_dm8806_reg_read(const struct device *dev, uint16_t reg_addr, uint
 	const struct phy_dm8806_config *cfg = dev->config;
 
 	res = mdio_read(cfg->mdio, cfg->switch_addr, reg_addr, (uint16_t *)data);
-	if (res) {
+	if (res < 0) {
 		LOG_ERR("Failed to read data from DM8806");
 		return res;
 	}
@@ -647,7 +645,7 @@ static int phy_dm8806_reg_write(const struct device *dev, uint16_t reg_addr, uin
 	const struct phy_dm8806_config *cfg = dev->config;
 
 	res = mdio_write(cfg->mdio, cfg->switch_addr, reg_addr, data);
-	if (res) {
+	if (res < 0) {
 		LOG_ERR("Failed to write data to DM8806");
 		return res;
 	}