Skip to content

Commit c875582

Browse files
rruuaanngkartben
authored andcommitted
lib: posix: Fix unchecked return value in rwlock
Fix 'sys_sem_xxx' functions unchecked return value scanned by Coverity. Signed-off-by: James Roy <[email protected]>
1 parent 5dd9ba0 commit c875582

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

lib/posix/options/rwlock.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -331,15 +331,15 @@ int pthread_rwlock_unlock(pthread_rwlock_t *rwlock)
331331
if (k_current_get() == rwl->wr_owner) {
332332
/* Write unlock */
333333
rwl->wr_owner = NULL;
334-
sys_sem_give(&rwl->reader_active);
335-
sys_sem_give(&rwl->wr_sem);
334+
(void)sys_sem_give(&rwl->reader_active);
335+
(void)sys_sem_give(&rwl->wr_sem);
336336
} else {
337337
/* Read unlock */
338-
sys_sem_give(&rwl->rd_sem);
338+
(void)sys_sem_give(&rwl->rd_sem);
339339

340340
if (sys_sem_count_get(&rwl->rd_sem) == CONCURRENT_READER_LIMIT) {
341341
/* Last read lock, unlock writer */
342-
sys_sem_give(&rwl->reader_active);
342+
(void)sys_sem_give(&rwl->reader_active);
343343
}
344344
}
345345
return 0;
@@ -350,9 +350,9 @@ static uint32_t read_lock_acquire(struct posix_rwlock *rwl, int32_t timeout)
350350
uint32_t ret = 0U;
351351

352352
if (sys_sem_take(&rwl->wr_sem, SYS_TIMEOUT_MS(timeout)) == 0) {
353-
sys_sem_take(&rwl->reader_active, K_NO_WAIT);
354-
sys_sem_take(&rwl->rd_sem, K_NO_WAIT);
355-
sys_sem_give(&rwl->wr_sem);
353+
(void)sys_sem_take(&rwl->reader_active, K_NO_WAIT);
354+
(void)sys_sem_take(&rwl->rd_sem, K_NO_WAIT);
355+
(void)sys_sem_give(&rwl->wr_sem);
356356
} else {
357357
ret = EBUSY;
358358
}
@@ -383,7 +383,7 @@ static uint32_t write_lock_acquire(struct posix_rwlock *rwl, int32_t timeout)
383383
if (sys_sem_take(&rwl->reader_active, k_timeout) == 0) {
384384
rwl->wr_owner = k_current_get();
385385
} else {
386-
sys_sem_give(&rwl->wr_sem);
386+
(void)sys_sem_give(&rwl->wr_sem);
387387
ret = EBUSY;
388388
}
389389

0 commit comments

Comments
 (0)