drivers/pwm: Fix abs() usage in xec driver

Tomasz Bursztyka · nashif · commit c9e0876421f7 · 2019-12-03T13:34:19.000-05:00
Seems to be fine to temporarly cast to int there as frequencies are in Mhz and not Ghz. Fixes #20497 Coverity CID: 205638 Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
diff --git a/drivers/pwm/pwm_mchp_xec.c b/drivers/pwm/pwm_mchp_xec.c
@@ -216,7 +216,8 @@ static struct xec_params *xec_compare_params(u32_t target_freq,
 				lc_params->off);
 	}
 
-	if (abs(target_freq - freq_h) < abs(target_freq - freq_l)) {
+	if (abs((int)target_freq - (int)freq_h) <
+	    abs((int)target_freq - (int)freq_l)) {
 		params = hc_params;
 	} else {
 		params = lc_params;

Original file line number	Diff line number	Diff line change
`@@ -216,7 +216,8 @@ static struct xec_params *xec_compare_params(u32_t target_freq,`
`216`	`216`	`lc_params->off);`
`217`	`217`	`}`
`218`	`218`
`219`		`- if (abs(target_freq - freq_h) < abs(target_freq - freq_l)) {`
	`219`	`+ if (abs((int)target_freq - (int)freq_h) <`
	`220`	`+ abs((int)target_freq - (int)freq_l)) {`
`220`	`221`	`params = hc_params;`
`221`	`222`	`} else {`
`222`	`223`	`params = lc_params;`