tests: drivers: wdt_basic_api: Add missing failure indications

anangl · nashif · commit ccedcd1ac04c · 2024-05-24T08:24:56.000-04:00
Two API calls that are supposed to set up the watchdog are not actually
causing the test to fail, only error messages are printed. This patch
adds the proper return statements.

Signed-off-by: Andrzej Głąbek &lt;andrzej.glabek@nordicsemi.no&gt;
diff --git a/tests/drivers/watchdog/wdt_basic_api/src/test_wdt.c b/tests/drivers/watchdog/wdt_basic_api/src/test_wdt.c
@@ -212,11 +212,13 @@ static int test_wdt_no_callback(void)
 	err = wdt_install_timeout(wdt, &m_cfg_wdt0);
 	if (err < 0) {
 		TC_PRINT("Watchdog install error\n");
+		return TC_FAIL;
 	}
 
 	err = wdt_setup(wdt, WDT_OPT_PAUSE_HALTED_BY_DBG);
 	if (err < 0) {
 		TC_PRINT("Watchdog setup error\n");
+		return TC_FAIL;
 	}
 
 	TC_PRINT("Waiting to restart MCU\n");

Original file line number	Diff line number	Diff line change
`@@ -212,11 +212,13 @@ static int test_wdt_no_callback(void)`
`212`	`212`	`err = wdt_install_timeout(wdt, &m_cfg_wdt0);`
`213`	`213`	`if (err < 0) {`
`214`	`214`	`TC_PRINT("Watchdog install error\n");`
	`215`	`+ return TC_FAIL;`
`215`	`216`	`}`
`216`	`217`
`217`	`218`	`err = wdt_setup(wdt, WDT_OPT_PAUSE_HALTED_BY_DBG);`
`218`	`219`	`if (err < 0) {`
`219`	`220`	`TC_PRINT("Watchdog setup error\n");`
	`221`	`+ return TC_FAIL;`
`220`	`222`	`}`
`221`	`223`
`222`	`224`	`TC_PRINT("Waiting to restart MCU\n");`