tests: net: sockets: af_packet: Fix recvfrom DGRAM test

rlubos · kartben · commit cd50608f243b · 2025-04-30T16:26:16.000+02:00
The recvfrom test case for DGRAM packet socket specified wrong socket
type, so RAW sockets were tested twice instead. Also, for the DGRAM
variant, the offset was not taken into account for the expected packet
length.

Signed-off-by: Robert Lubos &lt;robert.lubos@nordicsemi.no&gt;
diff --git a/tests/net/socket/af_packet/src/main.c b/tests/net/socket/af_packet/src/main.c
@@ -894,6 +894,8 @@ static void test_recvfrom_common(int sock_type, int proto)
 		offset = sizeof(struct net_eth_hdr);
 	}
 
+	pkt_len -= offset;
+
 	ret = zsock_recvfrom(packet_sock_2, rx_buf, sizeof(rx_buf), 0,
 			     (struct sockaddr *)&ll_rx, &addrlen);
 	zassert_not_equal(ret, -1, "Failed to receive packet (%d)", errno);
@@ -927,7 +929,7 @@ ZTEST(socket_packet, test_dgram_sock_recv_proto_wildcard)
 
 ZTEST(socket_packet, test_dgram_sock_recvfrom_proto_wildcard)
 {
-	test_recvfrom_common(SOCK_RAW, ETH_P_ALL);
+	test_recvfrom_common(SOCK_DGRAM, ETH_P_ALL);
 }
 
 ZTEST(socket_packet, test_raw_dgram_udp_socks_recv)

Original file line number	Diff line number	Diff line change
`@@ -894,6 +894,8 @@ static void test_recvfrom_common(int sock_type, int proto)`
`894`	`894`	`offset = sizeof(struct net_eth_hdr);`
`895`	`895`	`}`
`896`	`896`
	`897`	`+ pkt_len -= offset;`
	`898`	`+`
`897`	`899`	`ret = zsock_recvfrom(packet_sock_2, rx_buf, sizeof(rx_buf), 0,`
`898`	`900`	`(struct sockaddr *)&ll_rx, &addrlen);`
`899`	`901`	`zassert_not_equal(ret, -1, "Failed to receive packet (%d)", errno);`
`@@ -927,7 +929,7 @@ ZTEST(socket_packet, test_dgram_sock_recv_proto_wildcard)`
`927`	`929`
`928`	`930`	`ZTEST(socket_packet, test_dgram_sock_recvfrom_proto_wildcard)`
`929`	`931`	`{`
`930`		`- test_recvfrom_common(SOCK_RAW, ETH_P_ALL);`
	`932`	`+ test_recvfrom_common(SOCK_DGRAM, ETH_P_ALL);`
`931`	`933`	`}`
`932`	`934`
`933`	`935`	`ZTEST(socket_packet, test_raw_dgram_udp_socks_recv)`