Skip to content

Commit cfbe649

Browse files
franckduriezcfriedt
authored andcommitted
driver: pwm/pca9685: remove unimplemented misleading property
Invert property was not implemented and is now redundant with the flag pwm-cell which is more flexible in case you want some IO to be inverted and some not Signed-off-by: Franck Duriez <[email protected]> # Conflicts: # doc/releases/migration-guide-4.3.rst
1 parent ae88902 commit cfbe649

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

doc/releases/migration-guide-4.3.rst

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,14 @@ MFD
6565
kconfig symbol ``MFD_AXP192_AXP2101`` is removed. :kconfig:option:`MFD_AXP192` is now to be
6666
used for AXP192 device while :kconfig:option:`MFD_AXP2101` for the AXP2101 one.
6767

68+
PWM
69+
===
70+
71+
* :dtcompatible:`nxp,pca9685` ``invert`` property has been removed and you can now use the
72+
:c:macro:`PWM_POLARITY_INVERTED` or :c:macro:`PWM_POLARITY_NORMAL` flags as specifier cells for
73+
space "pwm" are now named: ``['channel', 'period', 'flags']`` (old value:
74+
``['channel', 'period']``) and ``#pwm-cells`` const value changed from 2 to 3.
75+
6876
Phy
6977
===
7078

drivers/pwm/pwm_pca9685.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,6 @@ struct pca9685_config {
7878
struct i2c_dt_spec i2c;
7979
bool outdrv_open_drain;
8080
bool och_on_ack;
81-
bool invrt;
8281
};
8382

8483
struct pca9685_data {
@@ -277,7 +276,6 @@ static int pca9685_init(const struct device *dev)
277276
.i2c = I2C_DT_SPEC_INST_GET(inst), \
278277
.outdrv_open_drain = DT_INST_PROP(inst, open_drain), \
279278
.och_on_ack = DT_INST_PROP(inst, och_on_ack), \
280-
.invrt = DT_INST_PROP(inst, invert), \
281279
}; \
282280
\
283281
static struct pca9685_data pca9685_##inst##_data; \

dts/bindings/pwm/nxp,pca9685.yaml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,6 @@ properties:
2323
Outputs change on ACK. Otherwise the outputs change on STOP
2424
command.
2525

26-
invert:
27-
type: boolean
28-
description:
29-
Output logic state inverted. Value to use when no external driver
30-
used.
31-
3226
"#pwm-cells":
3327
const: 3
3428

0 commit comments

Comments
 (0)