usb: device_next: bt_hci: do not take semaphore if transfer enqueue fail

jfischer-no · dkalowsk · commit d2e42c99ac80 · 2025-06-19T22:36:51.000-07:00
Do not take semaphore if transfer enqueue fails.

Signed-off-by: Johann Fischer &lt;johann.fischer@nordicsemi.no&gt;
diff --git a/subsys/usb/device_next/class/bt_hci.c b/subsys/usb/device_next/class/bt_hci.c
@@ -189,8 +189,12 @@ static void bt_hci_tx_sync_in(struct usbd_class_data *const c_data,
 	}
 
 	net_buf_add_mem(buf, bt_buf->data, bt_buf->len);
-	usbd_ep_enqueue(c_data, buf);
-	k_sem_take(&hci_data->sync_sem, K_FOREVER);
+	if (usbd_ep_enqueue(c_data, buf)) {
+		LOG_ERR("Failed to enqueue transfer");
+	} else {
+		k_sem_take(&hci_data->sync_sem, K_FOREVER);
+	}
+
 	net_buf_unref(buf);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -189,8 +189,12 @@ static void bt_hci_tx_sync_in(struct usbd_class_data *const c_data,`
`189`	`189`	`}`
`190`	`190`
`191`	`191`	`net_buf_add_mem(buf, bt_buf->data, bt_buf->len);`
`192`		`- usbd_ep_enqueue(c_data, buf);`
`193`		`- k_sem_take(&hci_data->sync_sem, K_FOREVER);`
	`192`	`+ if (usbd_ep_enqueue(c_data, buf)) {`
	`193`	`+ LOG_ERR("Failed to enqueue transfer");`
	`194`	`+ } else {`
	`195`	`+ k_sem_take(&hci_data->sync_sem, K_FOREVER);`
	`196`	`+ }`
	`197`	`+`
`194`	`198`	`net_buf_unref(buf);`
`195`	`199`	`}`
`196`	`200`