Skip to content

Commit d550320

Browse files
kapi-nocarlescufi
authored andcommitted
dts: arm: nordic: nrf5340: clean up ipc in dts
Cleaned up the IPC configuration for nRF5340 SoC in Device Tree. This change fixes the (simple_bus_reg) warning about the missing or empty reg/ranges property. This is a follow-up to commit cf6a58d. Signed-off-by: Kamil Piszczek <[email protected]>
1 parent 4616056 commit d550320

File tree

9 files changed

+98
-78
lines changed

9 files changed

+98
-78
lines changed

dts/arm/nordic/nrf5340_cpuapp.dtsi

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,11 @@
9797
};
9898
};
9999
};
100+
101+
/* Default IPC description */
102+
ipc {
103+
#include "nrf5340_cpuapp_ipc.dtsi"
104+
};
100105
};
101106

102107
&nvic {
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
/*
2+
* Copyright (c) 2022 Nordic Semiconductor ASA
3+
*
4+
* SPDX-License-Identifier: Apache-2.0
5+
*/
6+
7+
ipc0: ipc0 {
8+
compatible = "zephyr,ipc-openamp-static-vrings";
9+
memory-region = <&sram0_shared>;
10+
mboxes = <&mbox 0>, <&mbox 1>;
11+
mbox-names = "tx", "rx";
12+
role = "host";
13+
status = "okay";
14+
};

dts/arm/nordic/nrf5340_cpuapp_peripherals.dtsi

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -416,15 +416,6 @@ i2s0: i2s@28000 {
416416
label = "I2S_0";
417417
};
418418

419-
ipc0: ipc0 {
420-
compatible = "zephyr,ipc-openamp-static-vrings";
421-
memory-region = <&sram0_shared>;
422-
mboxes = <&mbox 0>, <&mbox 1>;
423-
mbox-names = "tx", "rx";
424-
role = "host";
425-
status = "okay";
426-
};
427-
428419
mbox: ipc: mbox@2a000 {
429420
compatible = "nordic,mbox-nrf-ipc", "nordic,nrf-ipc";
430421
reg = <0x2a000 0x1000>;

dts/arm/nordic/nrf5340_cpuappns.dtsi

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,11 @@
4949
#include "nrf5340_cpuapp_peripherals.dtsi"
5050
};
5151
};
52+
53+
/* Default IPC description */
54+
ipc {
55+
#include "nrf5340_cpuapp_ipc.dtsi"
56+
};
5257
};
5358

5459
&nvic {

dts/arm/nordic/nrf5340_cpunet.dtsi

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -153,15 +153,6 @@
153153
label = "RTC_0";
154154
};
155155

156-
ipc0: ipc0 {
157-
compatible = "zephyr,ipc-openamp-static-vrings";
158-
memory-region = <&sram0_shared>;
159-
mboxes = <&mbox 0>, <&mbox 1>;
160-
mbox-names = "rx", "tx";
161-
role = "remote";
162-
status = "okay";
163-
};
164-
165156
mbox: ipc: mbox@41012000 {
166157
compatible = "nordic,mbox-nrf-ipc", "nordic,nrf-ipc";
167158
reg = <0x41012000 0x1000>;
@@ -329,6 +320,18 @@
329320
port = <1>;
330321
};
331322
};
323+
324+
/* Default IPC description */
325+
ipc {
326+
ipc0: ipc0 {
327+
compatible = "zephyr,ipc-openamp-static-vrings";
328+
memory-region = <&sram0_shared>;
329+
mboxes = <&mbox 0>, <&mbox 1>;
330+
mbox-names = "rx", "tx";
331+
role = "remote";
332+
status = "okay";
333+
};
334+
};
332335
};
333336

334337
&nvic {

samples/subsys/ipc/ipc_service/icmsg/boards/nrf5340dk_nrf5340_cpuapp.overlay

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
* SPDX-License-Identifier: Apache-2.0
55
*/
66

7-
/delete-node/ &ipc0;
8-
97
/ {
108
chosen {
119
/delete-property/ zephyr,ipc_shm;
@@ -23,12 +21,16 @@
2321
};
2422
};
2523

26-
ipc0: ipc0 {
27-
compatible = "zephyr,ipc-icmsg";
28-
tx-region = <&sram_tx>;
29-
rx-region = <&sram_rx>;
30-
mboxes = <&mbox 0>, <&mbox 1>;
31-
mbox-names = "tx", "rx";
32-
status = "okay";
24+
ipc {
25+
/delete-node/ ipc0;
26+
27+
ipc0: ipc0 {
28+
compatible = "zephyr,ipc-icmsg";
29+
tx-region = <&sram_tx>;
30+
rx-region = <&sram_rx>;
31+
mboxes = <&mbox 0>, <&mbox 1>;
32+
mbox-names = "tx", "rx";
33+
status = "okay";
34+
};
3335
};
3436
};

samples/subsys/ipc/ipc_service/icmsg/remote/boards/nrf5340dk_nrf5340_cpunet.overlay

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44
* SPDX-License-Identifier: Apache-2.0
55
*/
66

7-
/delete-node/ &ipc0;
8-
97
/ {
108
chosen {
119
/delete-property/ zephyr,ipc_shm;
@@ -23,12 +21,16 @@
2321
};
2422
};
2523

26-
ipc0: ipc0 {
27-
compatible = "zephyr,ipc-icmsg";
28-
tx-region = <&sram_tx>;
29-
rx-region = <&sram_rx>;
30-
mboxes = <&mbox 0>, <&mbox 1>;
31-
mbox-names = "rx", "tx";
32-
status = "okay";
24+
ipc {
25+
/delete-node/ ipc0;
26+
27+
ipc0: ipc0 {
28+
compatible = "zephyr,ipc-icmsg";
29+
tx-region = <&sram_tx>;
30+
rx-region = <&sram_rx>;
31+
mboxes = <&mbox 0>, <&mbox 1>;
32+
mbox-names = "rx", "tx";
33+
status = "okay";
34+
};
3335
};
3436
};

samples/subsys/ipc/ipc_service/static_vrings/boards/nrf5340dk_nrf5340_cpuapp.overlay

Lines changed: 20 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,6 @@
1111
/delete-property/ zephyr,ipc_shm;
1212
};
1313

14-
soc {
15-
peripheral@50000000 {
16-
/delete-node/ ipc0;
17-
};
18-
};
19-
2014
reserved-memory {
2115
/delete-node/ memory@20070000;
2216

@@ -29,22 +23,26 @@
2923
};
3024
};
3125

32-
ipc0: ipc0 {
33-
compatible = "zephyr,ipc-openamp-static-vrings";
34-
memory-region = <&sram_ipc0>;
35-
mboxes = <&mbox 0>, <&mbox 1>;
36-
mbox-names = "tx", "rx";
37-
role = "host";
38-
status = "okay";
39-
};
26+
ipc {
27+
/delete-node/ ipc0;
4028

41-
ipc1: ipc1 {
42-
compatible = "zephyr,ipc-openamp-static-vrings";
43-
memory-region = <&sram_ipc1>;
44-
mboxes = <&mbox 2>, <&mbox 3>;
45-
mbox-names = "tx", "rx";
46-
role = "host";
47-
zephyr,priority = <1 PRIO_COOP>;
48-
status = "okay";
29+
ipc0: ipc0 {
30+
compatible = "zephyr,ipc-openamp-static-vrings";
31+
memory-region = <&sram_ipc0>;
32+
mboxes = <&mbox 0>, <&mbox 1>;
33+
mbox-names = "tx", "rx";
34+
role = "host";
35+
status = "okay";
36+
};
37+
38+
ipc1: ipc1 {
39+
compatible = "zephyr,ipc-openamp-static-vrings";
40+
memory-region = <&sram_ipc1>;
41+
mboxes = <&mbox 2>, <&mbox 3>;
42+
mbox-names = "tx", "rx";
43+
role = "host";
44+
zephyr,priority = <1 PRIO_COOP>;
45+
status = "okay";
46+
};
4947
};
5048
};

samples/subsys/ipc/ipc_service/static_vrings/remote/boards/nrf5340dk_nrf5340_cpunet.overlay

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,6 @@
1111
/delete-property/ zephyr,ipc_shm;
1212
};
1313

14-
soc {
15-
/delete-node/ ipc0;
16-
};
17-
1814
reserved-memory {
1915
/delete-node/ memory@20070000;
2016

@@ -27,22 +23,26 @@
2723
};
2824
};
2925

30-
ipc0: ipc0 {
31-
compatible = "zephyr,ipc-openamp-static-vrings";
32-
memory-region = <&sram_ipc0>;
33-
mboxes = <&mbox 0>, <&mbox 1>;
34-
mbox-names = "rx", "tx";
35-
role = "remote";
36-
status = "okay";
37-
};
26+
ipc {
27+
/delete-node/ ipc0;
28+
29+
ipc0: ipc0 {
30+
compatible = "zephyr,ipc-openamp-static-vrings";
31+
memory-region = <&sram_ipc0>;
32+
mboxes = <&mbox 0>, <&mbox 1>;
33+
mbox-names = "rx", "tx";
34+
role = "remote";
35+
status = "okay";
36+
};
3837

39-
ipc1: ipc1 {
40-
compatible = "zephyr,ipc-openamp-static-vrings";
41-
memory-region = <&sram_ipc1>;
42-
mboxes = <&mbox 2>, <&mbox 3>;
43-
mbox-names = "rx", "tx";
44-
role = "remote";
45-
zephyr,priority = <2 PRIO_PREEMPT>;
46-
status = "okay";
38+
ipc1: ipc1 {
39+
compatible = "zephyr,ipc-openamp-static-vrings";
40+
memory-region = <&sram_ipc1>;
41+
mboxes = <&mbox 2>, <&mbox 3>;
42+
mbox-names = "rx", "tx";
43+
role = "remote";
44+
zephyr,priority = <2 PRIO_PREEMPT>;
45+
status = "okay";
46+
};
4747
};
4848
};

0 commit comments

Comments
 (0)