Skip to content

Commit d6024c5

Browse files
ndrs-pstaescolar
authored andcommitted
tests: unit: crc: use zassert_equal for cleaner assertions
Replace `zassert` with `zassert_equal` in CRC8-CCITT and CRC8-ROHC test cases, as `zassert_equal` is more appropriate for comparing actual and expected values. Signed-off-by: Pisit Sawangvonganan <[email protected]>
1 parent ec5354c commit d6024c5

File tree

1 file changed

+9
-18
lines changed

1 file changed

+9
-18
lines changed

tests/unit/crc/main.c

Lines changed: 9 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -179,12 +179,9 @@ ZTEST(crc, test_crc8_ccitt)
179179
uint8_t test1[] = { 'A' };
180180
uint8_t test2[] = { '1', '2', '3', '4', '5', '6', '7', '8', '9' };
181181

182-
zassert(crc8_ccitt(CRC8_CCITT_INITIAL_VALUE, test0,
183-
sizeof(test0)) == 0xF3, "pass", "fail");
184-
zassert(crc8_ccitt(CRC8_CCITT_INITIAL_VALUE, test1,
185-
sizeof(test1)) == 0x33, "pass", "fail");
186-
zassert(crc8_ccitt(CRC8_CCITT_INITIAL_VALUE, test2,
187-
sizeof(test2)) == 0xFB, "pass", "fail");
182+
zassert_equal(crc8_ccitt(CRC8_CCITT_INITIAL_VALUE, test0, sizeof(test0)), 0xF3);
183+
zassert_equal(crc8_ccitt(CRC8_CCITT_INITIAL_VALUE, test1, sizeof(test1)), 0x33);
184+
zassert_equal(crc8_ccitt(CRC8_CCITT_INITIAL_VALUE, test2, sizeof(test2)), 0xFB);
188185
}
189186

190187
ZTEST(crc, test_crc8_rohc)
@@ -196,18 +193,12 @@ ZTEST(crc, test_crc8_rohc)
196193
uint8_t test4[] = { 0x07, 0x3F, 0x89 }; /* GSM 07.10 example */
197194
uint8_t test5[] = { 0x03, 0x3f, 0x01, 0x1c }; /* Our GSM 07.10 calc */
198195

199-
zassert(crc8_rohc(CRC8_ROHC_INITIAL_VALUE, test0,
200-
sizeof(test0)) == 0xcf, "pass", "fail");
201-
zassert(crc8_rohc(CRC8_ROHC_INITIAL_VALUE, test1,
202-
sizeof(test1)) == 0x2e, "pass", "fail");
203-
zassert(crc8_rohc(CRC8_ROHC_INITIAL_VALUE, test2,
204-
sizeof(test2)) == 0xd0, "pass", "fail");
205-
zassert(crc8_rohc(CRC8_ROHC_INITIAL_VALUE, test3,
206-
sizeof(test3)) == 0x76, "pass", "fail");
207-
zassert(crc8_rohc(CRC8_ROHC_INITIAL_VALUE, test4,
208-
sizeof(test4)) == 0xcf, "pass", "fail");
209-
zassert(crc8_rohc(CRC8_ROHC_INITIAL_VALUE, test5,
210-
sizeof(test5)) == 0xcf, "pass", "fail");
196+
zassert_equal(crc8_rohc(CRC8_ROHC_INITIAL_VALUE, test0, sizeof(test0)), 0xcf);
197+
zassert_equal(crc8_rohc(CRC8_ROHC_INITIAL_VALUE, test1, sizeof(test1)), 0x2e);
198+
zassert_equal(crc8_rohc(CRC8_ROHC_INITIAL_VALUE, test2, sizeof(test2)), 0xd0);
199+
zassert_equal(crc8_rohc(CRC8_ROHC_INITIAL_VALUE, test3, sizeof(test3)), 0x76);
200+
zassert_equal(crc8_rohc(CRC8_ROHC_INITIAL_VALUE, test4, sizeof(test4)), 0xcf);
201+
zassert_equal(crc8_rohc(CRC8_ROHC_INITIAL_VALUE, test5, sizeof(test5)), 0xcf);
211202
}
212203

213204
ZTEST(crc, test_crc7_be)

0 commit comments

Comments
 (0)