samples: mgmt: mcumgr: smp_svr: Fix re-advertise issue on connection

nordicjm · dkalowsk · commit d70bbe0eb6db · 2024-12-27T11:19:58.000-08:00
Fixes an issue introduced with commit c6ad4a7 which wrong restarts advertising after a device connects when it should only restart advertising if a device fails to connect Signed-off-by: Jamie McCrae <jamie.mccrae@nordicsemi.no> (cherry picked from commit 655be99)
diff --git a/samples/subsys/mgmt/mcumgr/smp_svr/src/bluetooth.c b/samples/subsys/mgmt/mcumgr/smp_svr/src/bluetooth.c
@@ -43,11 +43,10 @@ static void connected(struct bt_conn *conn, uint8_t err)
 {
 	if (err) {
 		LOG_ERR("Connection failed, err 0x%02x %s", err, bt_hci_err_to_str(err));
+		k_work_submit(&advertise_work);
 	} else {
 		LOG_INF("Connected");
 	}
-
-	k_work_submit(&advertise_work);
 }
 
 static void disconnected(struct bt_conn *conn, uint8_t reason)

Original file line number	Diff line number	Diff line change
`@@ -43,11 +43,10 @@ static void connected(struct bt_conn *conn, uint8_t err)`
`43`	`43`	`{`
`44`	`44`	`if (err) {`
`45`	`45`	`LOG_ERR("Connection failed, err 0x%02x %s", err, bt_hci_err_to_str(err));`
	`46`	`+ k_work_submit(&advertise_work);`
`46`	`47`	`} else {`
`47`	`48`	`LOG_INF("Connected");`
`48`	`49`	`}`
`49`		`-`
`50`		`- k_work_submit(&advertise_work);`
`51`	`50`	`}`
`52`	`51`
`53`	`52`	`static void disconnected(struct bt_conn *conn, uint8_t reason)`