net: coap: Fix uninitialized variable warning

DaveLacerte · kartben · commit d9aab69fbf86 · 2025-02-06T17:49:42.000+01:00
The variable block_len in function coap_next_block_for_option()
can be used uninitialized in case of empty packet in
coap_packet_get_payload(). Mute the compiler warning with
default value of 0.

Signed-off-by: Dave Lacerte &lt;lacerte.dave@hydroquebec.com&gt;
diff --git a/subsys/net/lib/coap/coap.c b/subsys/net/lib/coap/coap.c
@@ -1548,7 +1548,7 @@ int coap_next_block_for_option(const struct coap_packet *cpkt,
 			       enum coap_option_num option)
 {
 	int block;
-	uint16_t block_len;
+	uint16_t block_len = 0;
 
 	if (option != COAP_OPTION_BLOCK1 && option != COAP_OPTION_BLOCK2) {
 		return -EINVAL;

Original file line number	Diff line number	Diff line change
`@@ -1548,7 +1548,7 @@ int coap_next_block_for_option(const struct coap_packet *cpkt,`
`1548`	`1548`	`enum coap_option_num option)`
`1549`	`1549`	`{`
`1550`	`1550`	`int block;`
`1551`		`- uint16_t block_len;`
	`1551`	`+ uint16_t block_len = 0;`
`1552`	`1552`
`1553`	`1553`	`if (option != COAP_OPTION_BLOCK1 && option != COAP_OPTION_BLOCK2) {`
`1554`	`1554`	`return -EINVAL;`