settings: settings_register static table does not need mutex

It is not needed to protect static table of handlers, with mutex,
as there is no possibility that there will be anything added to the
table at runtime.

Signed-off-by: Dominik Ermel <[email protected]>

Author: de-nordic

subsys/settings/src/settings.c

@@ -38,17 +38,16 @@ void settings_init(void)
 #if defined(CONFIG_SETTINGS_DYNAMIC_HANDLERS)
 int settings_register(struct settings_handler *handler)
 {
-	int rc;
-
-	k_mutex_lock(&settings_lock, K_FOREVER);
+	int rc = 0;
 
 	Z_STRUCT_SECTION_FOREACH(settings_handler_static, ch) {
 		if (strcmp(handler->name, ch->name) == 0) {
-			rc = -EEXIST;
-			goto end;
+			return -EEXIST;
 		}
 	}
 
+	k_mutex_lock(&settings_lock, K_FOREVER);
+
 	struct settings_handler *ch;
 	SYS_SLIST_FOR_EACH_CONTAINER(&settings_handlers, ch, node) {
 		if (strcmp(handler->name, ch->name) == 0) {
@@ -57,7 +56,7 @@ int settings_register(struct settings_handler *handler)
 		}
 	}
 	sys_slist_append(&settings_handlers, &handler->node);
-	rc = 0;
+
 end:
 	k_mutex_unlock(&settings_lock);
 	return rc;