mgmt: mcumgr: grp: os_mgmt: Fix invalid return

nordicjm · fabiobaltieri · commit ddad1e6fb0bd · 2024-09-23T14:08:03.000+01:00
Fixes wrongly returning an SMP version 2 error code as an SMP
version 1 error code instead of adding it as an error

Signed-off-by: Jamie McCrae &lt;jamie.mccrae@nordicsemi.no&gt;
diff --git a/subsys/mgmt/mcumgr/grp/os_mgmt/src/os_mgmt.c b/subsys/mgmt/mcumgr/grp/os_mgmt/src/os_mgmt.c
@@ -505,7 +505,7 @@ os_mgmt_bootloader_info(struct smp_streamer *ctxt)
 	} else
 #endif
 	{
-		return OS_MGMT_ERR_QUERY_YIELDS_NO_ANSWER;
+		ok = smp_add_cmd_err(zse, MGMT_GROUP_ID_OS, OS_MGMT_ERR_QUERY_YIELDS_NO_ANSWER);
 	}
 
 	return ok ? MGMT_ERR_EOK : MGMT_ERR_EMSGSIZE;

Original file line number	Diff line number	Diff line change
`@@ -505,7 +505,7 @@ os_mgmt_bootloader_info(struct smp_streamer *ctxt)`
`505`	`505`	`} else`
`506`	`506`	`#endif`
`507`	`507`	`{`
`508`		`- return OS_MGMT_ERR_QUERY_YIELDS_NO_ANSWER;`
	`508`	`+ ok = smp_add_cmd_err(zse, MGMT_GROUP_ID_OS, OS_MGMT_ERR_QUERY_YIELDS_NO_ANSWER);`
`509`	`509`	`}`
`510`	`510`
`511`	`511`	`return ok ? MGMT_ERR_EOK : MGMT_ERR_EMSGSIZE;`