Skip to content

Commit e1de2eb

Browse files
committed
dfu: Kconfig: fix MCUBoot UPDATE_FOOTER_SIZE build warning
MCUBOOT_UPDATE_FOOTER_SIZE depends on MCUBOOT_IMG_MANAGER on Zephyr side, but Sysbuild tries to set it always on MCUboot side which results in the following annoying warning when building with IMG_MANAGER=n: "warning: MCUBOOT_UPDATE_FOOTER_SIZE (defined at subsys/dfu/Kconfig:55) was assigned the value '0x30' but got the value ''. Check these unsatisfied dependencies: MCUBOOT_IMG_MANAGER (=n), IMG_MANAGER (=n)" Since we cannot condition MCUBOOT_UPDATE_FOOTER_SIZE's use by Sysbuild on MCUboot side, because "it sets the config of the application before the application is configured...we cannot read any application configuration" at that moment (see [1] for the full quote), remove MCUBOOT_UPDATE_FOOTER_SIZE's dependence on MCUBOOT_IMG_MANAGER and make it depend on BOOTLOADER_MCUBOOT only. The symbol help text still says that it is only useful when MCUBOOT_IMG_MANAGER and MCUMGR_GRP_IMG_TOO_LARGE_SYSBUILD are set. [1] mcu-tools/mcuboot#2504 (comment) Signed-off-by: Abderrahmane JARMOUNI <[email protected]>
1 parent 196a1da commit e1de2eb

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

subsys/dfu/Kconfig

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -52,14 +52,6 @@ config MCUBOOT_TRAILER_SWAP_TYPE
5252
Disable this option if need to be compatible with earlier version
5353
of MCUBoot.
5454

55-
config MCUBOOT_UPDATE_FOOTER_SIZE
56-
hex "Estimated update footer size"
57-
default 0x0
58-
help
59-
Estimated size of update image data, which is used to prevent loading of firmware updates
60-
that MCUboot cannot update due to being too large. This should be set from sysbuild, only
61-
used when MCUMGR_GRP_IMG_TOO_LARGE_SYSBUILD is enabled.
62-
6355
config IMG_BLOCK_BUF_SIZE
6456
int "Image writer buffer size"
6557
default 512
@@ -103,3 +95,12 @@ config UPDATEABLE_IMAGE_NUMBER
10395
endif
10496

10597
endif # IMG_MANAGER
98+
99+
config MCUBOOT_UPDATE_FOOTER_SIZE
100+
hex "Estimated update footer size"
101+
depends on BOOTLOADER_MCUBOOT
102+
default 0x0
103+
help
104+
Estimated size of update image data, which is used to prevent loading of firmware updates
105+
that MCUboot cannot update due to being too large. This should be set from sysbuild, only
106+
used when MCUBOOT_IMG_MANAGER and MCUMGR_GRP_IMG_TOO_LARGE_SYSBUILD are enabled.

0 commit comments

Comments
 (0)