drivers: clock_control: nrf: Fix missing clock started callback

804e502 fix got reverted as it introduced a bug where callback
with HFCLK started indication was not called because state is not
correctly indicated. BT-dedicated API does not set state and does
not expect to get the callback when HFCLK is started. 804e502
was intended to fix the bug that was visible on nrf54lx. It was not
visible on nrf52 because of a errata workaround which was calling
HFCLK started callback only when state was set to STARTING and that
was not the case when BT-dedicated API was used. Applying this
`workaround` approach to all cases.

Signed-off-by: Krzysztof Chruściński <[email protected]>

Author: nordic-krch

drivers/clock_control/clock_control_nrf.c

@@ -494,7 +494,7 @@ static int async_start(const struct device *dev, clock_control_subsys_t subsys,
 	subdata->cb = cb;
 	subdata->user_data = user_data;
 
-	 get_sub_config(dev, type)->start();
+	get_sub_config(dev, type)->start();
 
 	return 0;
 }
@@ -695,14 +695,28 @@ void z_nrf_clock_control_lf_on(enum nrf_lfclk_start_mode start_mode)
 	}
 }
 
+static void hfclkstarted_handle(const struct device *dev)
+{
+	struct nrf_clock_control_sub_data *data =
+			get_sub_data(dev, CLOCK_CONTROL_NRF_TYPE_HFCLK);
+
+	if (GET_STATUS(data->flags) == CLOCK_CONTROL_STATUS_STARTING) {
+		/* Handler is called only if state is set. BT specific API
+		 * does not set this state and does not require handler to
+		 * be called.
+		 */
+		clkstarted_handle(dev, CLOCK_CONTROL_NRF_TYPE_HFCLK);
+	}
+}
+
 static void clock_event_handler(nrfx_clock_evt_type_t event)
 {
 	const struct device *dev = CLOCK_DEVICE;
 
 	switch (event) {
 #if NRF_CLOCK_HAS_XO_TUNE
 	case NRFX_CLOCK_EVT_XO_TUNED:
-		clkstarted_handle(dev, CLOCK_CONTROL_NRF_TYPE_HFCLK);
+		hfclkstarted_handle(dev);
 		break;
 	case NRFX_CLOCK_EVT_XO_TUNE_ERROR:
 	case NRFX_CLOCK_EVT_XO_TUNE_FAILED:
@@ -716,19 +730,8 @@ static void clock_event_handler(nrfx_clock_evt_type_t event)
 #else
 	/* HFCLK started should be used only if tune operation is done implicitly. */
 	case NRFX_CLOCK_EVT_HFCLK_STARTED:
-	{
-		struct nrf_clock_control_sub_data *data =
-				get_sub_data(dev, CLOCK_CONTROL_NRF_TYPE_HFCLK);
-
-		/* Check needed due to anomaly 201:
-		 * HFCLKSTARTED may be generated twice.
-		 */
-		if (GET_STATUS(data->flags) == CLOCK_CONTROL_STATUS_STARTING) {
-			clkstarted_handle(dev, CLOCK_CONTROL_NRF_TYPE_HFCLK);
-		}
-
+		hfclkstarted_handle(dev);
 		break;
-	}
 #endif
 #if NRF_CLOCK_HAS_HFCLK24M
 	case NRFX_CLOCK_EVT_HFCLK24M_STARTED: