Skip to content

Commit e318401

Browse files
nordic-krchMaureenHelm
authored andcommitted
tests: drivers: counter: Fix coverity issues 190937, 190967, 190983
Fix issue reported by coverity regarding using volatile variable in zassert_equal macro. Signed-off-by: Krzysztof Chruscinski <[email protected]>
1 parent f084c38 commit e318401

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

tests/drivers/counter/counter_basic_api/src/test_counter.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -205,10 +205,10 @@ void test_single_shot_alarm_instance(const char *dev_name, bool set_top)
205205
zassert_equal(0, err, "Counter set alarm failed\n");
206206

207207
k_busy_wait(1.5*counter_ticks_to_us(dev, ticks));
208-
zassert_equal(1, alarm_cnt, "Expecting alarm callback\n");
208+
zassert_equal(1, (u32_t)alarm_cnt, "Expecting alarm callback\n");
209209

210210
k_busy_wait(1.5*counter_ticks_to_us(dev, ticks));
211-
zassert_equal(1, alarm_cnt, "Expecting alarm callback\n");
211+
zassert_equal(1, (u32_t)alarm_cnt, "Expecting alarm callback\n");
212212

213213
err = counter_cancel_channel_alarm(dev, 0);
214214
zassert_equal(0, err, "Counter disabling alarm failed\n");
@@ -302,7 +302,7 @@ void test_multiple_alarms_instance(const char *dev_name)
302302
zassert_equal(0, err, "Counter set alarm failed\n");
303303

304304
k_busy_wait(1.2*counter_ticks_to_us(dev, 2*ticks));
305-
zassert_equal(2, alarm_cnt, "Counter set alarm failed\n");
305+
zassert_equal(2, (u32_t)alarm_cnt, "Counter set alarm failed\n");
306306
zassert_equal(&alarm_cfg2, clbk_data[0],
307307
"Expected different order or callbacks\n");
308308
zassert_equal(&alarm_cfg, clbk_data[1],
@@ -355,7 +355,7 @@ void test_all_channels_instance(const char *str)
355355
}
356356

357357
k_busy_wait(1.5*counter_ticks_to_us(dev, ticks));
358-
zassert_equal(nchan, alarm_cnt, "Expecting alarm callback\n");
358+
zassert_equal(nchan, (u32_t)alarm_cnt, "Expecting alarm callback\n");
359359

360360
for (int i = 0; i < nchan; i++) {
361361
err = counter_cancel_channel_alarm(dev, i);

0 commit comments

Comments
 (0)