tests: Bluetooth: df: Move common code to separate source file

Move common code that may be used by different test units
from main.c to common.c. Main.c should be clean and responsible
for unit tests executioon only. Common functionalities should be
stored in separate file and provided to test source files by
appropriate header file.

Signed-off-by: Piotr Pryga <[email protected]>

Author: ppryga-nordic

tests/bluetooth/df/src/common.c

@@ -0,0 +1,55 @@
+/*
+ * Copyright (c) 2021 Nordic Semiconductor ASA
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+#include <zephyr.h>
+#include <stddef.h>
+#include <ztest.h>
+
+#include <bluetooth/bluetooth.h>
+#include <bluetooth/hci.h>
+#include <bluetooth/direction.h>
+#include <host/hci_core.h>
+
+#include "common.h"
+
+struct bt_le_ext_adv *g_adv;
+struct bt_le_adv_param g_param =
+		BT_LE_ADV_PARAM_INIT(BT_LE_ADV_OPT_EXT_ADV |
+				     BT_LE_ADV_OPT_NOTIFY_SCAN_REQ,
+				     BT_GAP_ADV_FAST_INT_MIN_2,
+				     BT_GAP_ADV_FAST_INT_MAX_2,
+				     NULL);
+
+static struct bt_le_per_adv_param per_param = {
+	.interval_min = BT_GAP_ADV_SLOW_INT_MIN,
+	.interval_max = BT_GAP_ADV_SLOW_INT_MAX,
+	.options = BT_LE_ADV_OPT_USE_TX_POWER,
+};
+
+void common_setup(void)
+{
+	int err;
+
+	/* Initialize bluetooth subsystem */
+	err = bt_enable(NULL);
+	zassert_equal(err, 0, "Bluetooth subsystem initialization failed");
+}
+
+void common_create_adv_set(void)
+{
+	int err;
+
+	err = bt_le_ext_adv_create(&g_param, NULL, &g_adv);
+	zassert_equal(err, 0, "Failed to create advertiser set");
+}
+
+void common_delete_adv_set(void)
+{
+	int err;
+
+	err = bt_le_ext_adv_delete(g_adv);
+	zassert_equal(err, 0, "Failed to delete advertiser set");
+}

tests/bluetooth/df/src/common.h

@@ -0,0 +1,12 @@
+/*
+ * Copyright (c) 2021 Nordic Semiconductor ASA
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+extern struct bt_le_ext_adv *g_adv;
+extern struct bt_le_adv_param g_param;
+
+void common_setup(void);
+void common_create_adv_set(void);
+void common_delete_adv_set(void);

tests/bluetooth/df/src/main.c

@@ -4,48 +4,16 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-#include <zephyr.h>
-#include <stddef.h>
-#include <ztest.h>
-
-#include <bluetooth/bluetooth.h>
-#include <bluetooth/hci.h>
-#include <sys/byteorder.h>
+#include <stdint.h>
 
+#include "common.h"
 #include "test_set_cl_cte_tx_params.h"
 
-struct bt_le_ext_adv *g_adv;
-
-static void common_setup(void)
-{
-	static struct bt_le_adv_param param =
-			BT_LE_ADV_PARAM_INIT(BT_LE_ADV_OPT_EXT_ADV |
-					     BT_LE_ADV_OPT_NOTIFY_SCAN_REQ,
-					     BT_GAP_ADV_FAST_INT_MIN_2,
-					     BT_GAP_ADV_FAST_INT_MAX_2,
-					     NULL);
-	struct bt_le_per_adv_param per_param = {
-		.interval_min = BT_GAP_ADV_SLOW_INT_MIN,
-		.interval_max = BT_GAP_ADV_SLOW_INT_MAX,
-		.options = BT_LE_ADV_OPT_USE_TX_POWER,
-	};
-	int err;
-
-	/* Initialize bluetooth subsystem */
-	err = bt_enable(NULL);
-	zassert_equal(err, 0, "Bluetooth subsystem initialization failed");
-
-	err = bt_le_ext_adv_create(&param, NULL, &g_adv);
-	zassert_equal(err, 0, "Failed to create advertiser set");
-
-
-	err = bt_le_per_adv_set_param(g_adv, &per_param);
-	zassert_equal(err, 0, "Failed to set periodic advertising params");
-}
 
 /*test case main entry*/
 void test_main(void)
 {
 	common_setup();
+	common_create_adv_set();
 	run_set_cl_cte_tx_params_tests();
 }

tests/bluetooth/df/src/test_set_cl_cte_tx_param.c

@@ -13,7 +13,7 @@
 #include <sys/byteorder.h>
 #include <host/hci_core.h>
 
-extern struct bt_le_ext_adv *g_adv;
+#include "common.h"
 
 /* Macros delivering common values for unit tests */
 #define CTE_LEN_VALID                   (BT_HCI_LE_CTE_LEN_MIN + 5)