lib: os: cbprintf: Suppress coverity false positive

nordic-krch · carlescufi · commit e5eb1b179de8 · 2021-04-28T20:06:20.000+02:00
Coverity is complaining about sizeof(v + 0) and it is used
here intentionally to promote variable. Added comment that should
suppress this error in the future.

Note that this macro will be used in all log messages so without
solving it before logging v2 is merged there will be a flood of
errors.

Signed-off-by: Krzysztof Chruscinski &lt;krzysztof.chruscinski@nordicsemi.no&gt;
diff --git a/include/sys/cbprintf_internal.h b/include/sys/cbprintf_internal.h
@@ -127,7 +127,8 @@ extern "C" {
 	_Generic((v), \
 		float : sizeof(double), \
 		default : \
-			sizeof((v)+0) \
+			/* coverity[bad_sizeof] */ \
+			sizeof((v) + 0) \
 		)
 
 static inline void cbprintf_wcpy(int *dst, int *src, size_t len)

Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,8 @@ extern "C" {`
`127`	`127`	`_Generic((v), \`
`128`	`128`	`float : sizeof(double), \`
`129`	`129`	`default : \`
`130`		`- sizeof((v)+0) \`
	`130`	`+ /* coverity[bad_sizeof] */ \`
	`131`	`+ sizeof((v) + 0) \`
`131`	`132`	`)`
`132`	`133`
`133`	`134`	`static inline void cbprintf_wcpy(int dst, int src, size_t len)`