sysbuild: use ARGN instead of ARGV1

tejlmand · fabiobaltieri · commit e65c6328ce32 · 2024-05-27T14:05:38.000+01:00
Use of ARGV1 is undefined when number of arguments to function is less
than 2. Therefore switch to ARGN which holds arguments beyond required
arguments.
If there are no optional arguments, then ARGN is just an empty list,
thus making it safe to use.

Signed-off-by: Torsten Rasmussen &lt;Torsten.Rasmussen@nordicsemi.no&gt;
diff --git a/share/sysbuild/cmake/modules/sysbuild_extensions.cmake b/share/sysbuild/cmake/modules/sysbuild_extensions.cmake
@@ -661,7 +661,7 @@ function(sysbuild_add_subdirectory source_dir)
       " (expected at most 2, got ${ARGC})"
     )
   endif()
-  set(binary_dir ${ARGV1})
+  set(binary_dir ${ARGN})
 
   # Update SYSBUILD_CURRENT_SOURCE_DIR in this scope, to support nesting
   # of sysbuild_add_subdirectory() and even regular add_subdirectory().

Original file line number	Diff line number	Diff line change
`@@ -661,7 +661,7 @@ function(sysbuild_add_subdirectory source_dir)`
`661`	`661`	`" (expected at most 2, got ${ARGC})"`
`662`	`662`	`)`
`663`	`663`	`endif()`
`664`		`- set(binary_dir ${ARGV1})`
	`664`	`+ set(binary_dir ${ARGN})`
`665`	`665`
`666`	`666`	`# Update SYSBUILD_CURRENT_SOURCE_DIR in this scope, to support nesting`
`667`	`667`	`# of sysbuild_add_subdirectory() and even regular add_subdirectory().`