Skip to content

Commit e71448a

Browse files
Yuriy Vynnychekcarlescufi
authored andcommitted
shell: fix missing "update" for the last RXRDY signal
Fixed the issue when sometimes "update" is not called for the last RXRDY signal. First, need to reset the signal and only after that need to call the "update" function. Signed-off-by: Yuriy Vynnychek <[email protected]>
1 parent 86469b1 commit e71448a

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

subsys/shell/shell.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1330,17 +1330,17 @@ void shell_thread(void *shell_handle, void *arg_log_backend,
13301330

13311331
k_mutex_lock(&shell->ctx->wr_mtx, K_FOREVER);
13321332

1333-
if (shell->iface->api->update) {
1334-
shell->iface->api->update(shell->iface);
1335-
}
1336-
13371333
shell_signal_handle(shell, SHELL_SIGNAL_KILL, kill_handler);
13381334
shell_signal_handle(shell, SHELL_SIGNAL_RXRDY, shell_process);
13391335
if (IS_ENABLED(CONFIG_SHELL_LOG_BACKEND)) {
13401336
shell_signal_handle(shell, SHELL_SIGNAL_LOG_MSG,
13411337
shell_log_process);
13421338
}
13431339

1340+
if (shell->iface->api->update) {
1341+
shell->iface->api->update(shell->iface);
1342+
}
1343+
13441344
k_mutex_unlock(&shell->ctx->wr_mtx);
13451345
}
13461346
}

0 commit comments

Comments
 (0)