drivers: firmware: scmi: add msg_type validation in callback

In the SCMI core layer, add msg_type validation before dispatch
(e.g. RESP vs NOTIFY vs CMD). Messages with an unexpected or invalid
type for the current context are logged

Signed-off-by: Yongxu Wang <[email protected]>

Author: yongxu-wang15

drivers/firmware/scmi/core.c

@@ -43,8 +43,23 @@ int scmi_status_to_errno(int scmi_status)
 	}
 }
 
-static void scmi_core_reply_cb(struct scmi_channel *chan)
+static void scmi_core_reply_cb(struct scmi_channel *chan, int hdr)
 {
+	int msg_type;
+
+	msg_type = SCMI_MESSAGE_HDR_TAKE_TYPE(hdr);
+
+	switch (msg_type) {
+	case SCMI_COMMAND:
+		break;
+	case SCMI_DELAYED_REPLY:
+		break;
+	case SCMI_NOTIFICATION:
+		break;
+	default:
+		LOG_WRN("Unexpected message type %u", msg_type);
+	}
+
 	if (!k_is_pre_kernel()) {
 		k_sem_give(&chan->sem);
 	}

drivers/firmware/scmi/mailbox.c

@@ -41,7 +41,7 @@ static void scmi_mbox_tx_reply_cb(const struct device *mbox,
 	scmi_mbox_get_pending_msg(scmi_chan, &msg);
 
 	if (scmi_chan->cb) {
-		scmi_chan->cb(scmi_chan);
+		scmi_chan->cb(scmi_chan, msg.hdr);
 	}
 }
 
@@ -58,7 +58,7 @@ static void scmi_mbox_rx_notify_cb(const struct device *mbox,
 	scmi_mbox_get_pending_msg(scmi_chan, &msg);
 
 	if (scmi_chan->cb) {
-		scmi_chan->cb(scmi_chan);
+		scmi_chan->cb(scmi_chan, msg.hdr);
 		scmi_shmem_clear_channel_status(shmem);
 	}
 }

include/zephyr/drivers/firmware/scmi/transport.h

@@ -31,8 +31,9 @@ struct scmi_channel;
  *
  * @param chan pointer to SCMI channel on which the reply
  * arrived
+ * @param hdr is the share memory Message header
  */
-typedef void (*scmi_channel_cb)(struct scmi_channel *chan);
+typedef void (*scmi_channel_cb)(struct scmi_channel *chan, int hdr);
 
 /**
  * @struct scmi_channel