drivers: eeprom: stm32: don't mix HAL return value and errno

Correct eeprom_stm32_write() to return a valid errno instead
of mixing HAL return values and errno return values.

Clarify HAL return value is of type HAL_StatusTypeDef and not an
int in eeprom_stm32_read().

Remove printing of HAL_FLASHEx_DATAEEPROM_Lock() error code since
not very useful.

Signed-off-by: Etienne Carriere <[email protected]>

Author: etienne-lms

drivers/eeprom/eeprom_stm32.c

@@ -57,7 +57,7 @@ static int eeprom_stm32_write(const struct device *dev, off_t offset,
 {
 	const struct eeprom_stm32_config *config = dev->config;
 	const uint8_t *pbuf = buf;
-	HAL_StatusTypeDef ret = HAL_OK;
+	HAL_StatusTypeDef hal_ret;
 
 	if (!len) {
 		return 0;
@@ -73,29 +73,30 @@ static int eeprom_stm32_write(const struct device *dev, off_t offset,
 	HAL_FLASHEx_DATAEEPROM_Unlock();
 
 	while (len) {
-		ret = HAL_FLASHEx_DATAEEPROM_Program(
-						FLASH_TYPEPROGRAMDATA_BYTE,
-						config->addr + offset, *pbuf);
-		if (ret) {
-			LOG_ERR("failed to write to EEPROM (err %d)", ret);
+		hal_ret = HAL_FLASHEx_DATAEEPROM_Program(FLASH_TYPEPROGRAMDATA_BYTE,
+							 config->addr + offset, *pbuf);
+		if (hal_ret != HAL_OK) {
+			LOG_ERR("failed to write to EEPROM (err %d)", hal_ret);
 			HAL_FLASHEx_DATAEEPROM_Lock();
 			k_mutex_unlock(&lock);
-			return ret;
+			return -EIO;
 		}
 
 		pbuf++;
 		offset++;
 		len--;
 	}
 
-	ret = HAL_FLASHEx_DATAEEPROM_Lock();
-	if (ret) {
-		LOG_ERR("failed to lock EEPROM (err %d)", ret);
-	}
+	hal_ret = HAL_FLASHEx_DATAEEPROM_Lock();
 
 	k_mutex_unlock(&lock);
 
-	return ret;
+	if (hal_ret != HAL_OK) {
+		LOG_ERR("failed to lock EEPROM");
+		return -EIO;
+	}
+
+	return 0;
 }
 
 static size_t eeprom_stm32_size(const struct device *dev)